lp://staging/~adam-collard/click-reviewers-tools/store-requests-category

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/click-reviewers-tools at revision 1222

Jamie Strandboge (community): Approve on 2019-04-11

Diff: 110 lines (+11/-10)

5 files modified

clickreviews/sr_lint.py (+1/-1)
clickreviews/sr_security.py (+2/-1)
clickreviews/tests/test_sr_lint.py (+1/-1)
clickreviews/tests/test_sr_security.py (+1/-1)
tests/test.sh.expected (+6/-6)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1222. By Adam Collard on 2019-04-11

store ➡️store-requests

1221. By Jamie Strandboge on 2019-04-10

overrides.py: add stlouis-kernel

1220. By Jamie Strandboge on 2019-04-10

overrides.py: add a couple more Canonical Stack snaps and adjust bluez

1219. By Jamie Strandboge on 2019-04-10

bin/create-snap-declaration: clarify output

1218. By Jamie Strandboge on 2019-04-09

add personal-files override for aws-sam-cli

1217. By Jamie Strandboge on 2019-04-09

add tests/test-personal-files_1_all.snap

1216. By Jamie Strandboge on 2019-04-09

clickreviews/common.py: one more s/dpkg/os_dpkg/

1215. By Jamie Strandboge on 2019-04-09

clickreviews/common.py: in get_snap_manifest(), s/dpkg/os_dpkg/

1214. By Jamie Strandboge on 2019-04-09

overrides.py/sr_security.py: add a temporary tests to enforce the snap at least
uses the agreed to interface reference. Importantly, we don't reencode the
snap decl in overrides.py, so we don't enforce the interface reference is used
with a particular set of interface attributes.

Include all the known users of personal-files and system-files

References:
https://forum.snapcraft.io/t/requesting-auto-connection-of-personal-files-to-sam-cli/10641/10

1213. By Jamie Strandboge on 2019-04-09

clickreviews/sr_declaration.py: if the interface is already in the top-level,
no need to review the apps' plugs/slots since snapd enforces that the apps'
plugs/slots are used consistently through the install/connent/auto-connect
process