Merge lp://staging/~adam-collard/charms/trusty/swift-proxy/lib-in-python-package into lp://staging/~openstack-charmers-archive/charms/trusty/swift-proxy/next

Proposed by Adam Collard
Status: Merged
Merged at revision: 107
Proposed branch: lp://staging/~adam-collard/charms/trusty/swift-proxy/lib-in-python-package
Merge into: lp://staging/~openstack-charmers-archive/charms/trusty/swift-proxy/next
Diff against target: 396 lines (+120/-52)
13 files modified
.coveragerc (+1/-0)
Makefile (+3/-3)
charm-helpers-hooks.yaml (+1/-1)
charmhelpers/contrib/openstack/utils.py (+4/-0)
charmhelpers/contrib/storage/linux/ceph.py (+2/-11)
charmhelpers/core/kernel.py (+68/-0)
hooks/swift_hooks.py (+1/-1)
lib/swift_context.py (+7/-1)
setup.cfg (+1/-1)
unit_tests/__init__.py (+0/-2)
unit_tests/test_swift_context.py (+7/-7)
unit_tests/test_swift_hooks.py (+2/-1)
unit_tests/test_swift_utils.py (+23/-24)
To merge this branch: bzr merge lp://staging/~adam-collard/charms/trusty/swift-proxy/lib-in-python-package
Reviewer Review Type Date Requested Status
Chris Glass (community) Approve
Landscape Pending
Review via email: mp+270304@code.staging.launchpad.net

Description of the change

With the addition of actions to the OpenStack charms, there's a need to share code between actions and hooks. This branch moves library code to a top-level ./lib/ and then symlinks that into ./hooks/lib, likewise for charm-helpers.

This should be a plain refactor with no change in behaviour, but laying the ground for an actions/lib symlink and an actions/charm-helpers symlink.

(see https://code.launchpad.net/~adam-collard/charms/precise/swift-storage/lib-in-python-package/+merge/265105 for the equivalent MP for swift-storage)

To post a comment you must log in.
110. By Adam Collard

Add explanatory comment

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #9540 swift-proxy-next for adam-collard mp270304
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/9540/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #8781 swift-proxy-next for adam-collard mp270304
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/8781/

Revision history for this message
Chris Glass (tribaal) wrote :

I think this looks good, small comment inline.

111. By Adam Collard

Add missing @property (tribaal's review)

Revision history for this message
Adam Collard (adam-collard) :
Revision history for this message
Chris Glass (tribaal) wrote :

Looks good!

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6311 swift-proxy-next for adam-collard mp270304
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12307641/
Build: http://10.245.162.77:8080/job/charm_amulet_test/6311/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches