Merge lp://staging/~ack/storm/resultset-get-query into lp://staging/storm

Proposed by Alberto Donato
Status: Work in progress
Proposed branch: lp://staging/~ack/storm/resultset-get-query
Merge into: lp://staging/storm
Diff against target: 66 lines (+37/-1)
2 files modified
storm/store.py (+12/-1)
tests/store/base.py (+25/-0)
To merge this branch: bzr merge lp://staging/~ack/storm/resultset-get-query
Reviewer Review Type Date Requested Status
Christopher Armstrong (community) Approve
Storm Developers Pending
Storm Developers Pending
Review via email: mp+133871@code.staging.launchpad.net

Description of the change

This adds a get_query() method to ResultSet, returning the query and parameters that generated the resultset.
Mostly intended for debugging purpose.

To post a comment you must log in.
Revision history for this message
Christopher Armstrong (radix) wrote :

[1] I think this should use the database-specific compile function to make sure that the query that is returned is exactly what will be sent to the database.

455. By Alberto Donato

Use the Connection compile function.

Revision history for this message
Alberto Donato (ack) wrote :

> [1] I think this should use the database-specific compile function to make
> sure that the query that is returned is exactly what will be sent to the
> database.

Done! thanks

Revision history for this message
Christopher Armstrong (radix) wrote :

Looks good.

review: Approve

Unmerged revisions

455. By Alberto Donato

Use the Connection compile function.

454. By Alberto Donato

Add get_query().

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: