Storm

Merge lp://staging/~ack/storm/expr-is-in-resultset into lp://staging/storm

  1. expr-is-in-resultset
  2. Merge into trunk
Proposed by Alberto Donato
Status: Merged
Merged at revision: 483
Proposed branch: lp://staging/~ack/storm/expr-is-in-resultset
Merge into: lp://staging/storm
Diff against target: 52 lines (+22/-2)
2 files modified
storm/expr.py (+6/-1)
tests/store/base.py (+16/-1)
To merge this branch: bzr merge lp://staging/~ack/storm/expr-is-in-resultset
Reviewer Review Type Date Requested Status
Free Ekanayaka (community) Approve
Review via email: mp+294599@code.staging.launchpad.net

Description of the change

This change allows to use a subquery (insted of performing two separate queries) when the Comparable.is_in(ResultSet) expression is used.

To post a comment you must log in.
Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

+1 with a couple of comments.

review: Approve
Revision history for this message
Alberto Donato (ack) wrote :

@Free, thanks, fixed as suggested.

lp://staging/~ack/storm/expr-is-in-resultset updated
484. By Alberto Donato

Address review comments.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: