MAAS

Merge ~ack/maas:1869300-3.0 into maas:3.0

  1. Git
  2. lp:~ack/maas
  3. 1869300-3.0
  4. Merge into 3.0
Proposed by Alberto Donato
Status: Merged
Approved by: Alberto Donato
Approved revision: 0ab0c4921cff1ba4b5b12fdfc352bde78807c314
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ack/maas:1869300-3.0
Merge into: maas:3.0
Diff against target: 401 lines (+120/-113)
2 files modified
src/provisioningserver/drivers/pod/tests/test_virsh.py (+85/-70)
src/provisioningserver/drivers/pod/virsh.py (+35/-43)
Reviewer Review Type Date Requested Status
MAAS Lander Approve
Alberto Donato (community) Approve
Review via email: mp+404881@code.staging.launchpad.net

Commit message

refactor VirshSSH.create_local_volume to reduce duplication in command line

This also remove useless passing of --format raw where it's ignored

To post a comment you must log in.
Revision history for this message
Alberto Donato (ack) :
review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

LANDING
-b 1869300-3.0 lp:~ack/maas/+git/maas into -b 3.0 lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10345/consoleText

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b 1869300-3.0 lp:~ack/maas/+git/maas into -b 3.0 lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10346/console
COMMIT: 9d417c5f81c31536f2a6dc9003fe5458da230c1c

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

LANDING
-b 1869300-3.0 lp:~ack/maas/+git/maas into -b 3.0 lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10348/consoleText

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b 1869300-3.0 lp:~ack/maas/+git/maas into -b 3.0 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 0ab0c4921cff1ba4b5b12fdfc352bde78807c314

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches