MAAS

Merge ~ack/maas:virsh-create-vol-rework into maas:master

  1. Git
  2. lp:~ack/maas
  3. virsh-create-vol-rework
  4. Merge into master
Proposed by Alberto Donato
Status: Merged
Approved by: Alberto Donato
Approved revision: e7f1ae2f088475af62ff9e9c418ceb055cdf95a8
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ack/maas:virsh-create-vol-rework
Merge into: maas:master
Diff against target: 335 lines (+89/-72)
2 files modified
src/provisioningserver/drivers/pod/tests/test_virsh.py (+55/-31)
src/provisioningserver/drivers/pod/virsh.py (+34/-41)
Reviewer Review Type Date Requested Status
Lee Trager (community) Approve
MAAS Lander Approve
Review via email: mp+403335@code.staging.launchpad.net

Commit message

refactor VirshSSH.create_local_volume to reduce duplication in command line

This also remove useless passing of --format raw where it's ignored

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b virsh-create-vol-rework lp:~ack/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10141/console
COMMIT: 7e90feafae26cdbef36644d68db4750e817259f9

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b virsh-create-vol-rework lp:~ack/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10142/console
COMMIT: 9fc5ef78c8b5eda757a9e0c26b8425711d261a9b

review: Needs Fixing
Revision history for this message
Alberto Donato (ack) wrote :

jenkins: !test

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b virsh-create-vol-rework lp:~ack/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10144/console
COMMIT: 9fc5ef78c8b5eda757a9e0c26b8425711d261a9b

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b virsh-create-vol-rework lp:~ack/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10148/console
COMMIT: 4450ef6af95876957ef22edccdd1b34394451abc

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b virsh-create-vol-rework lp:~ack/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: e7f1ae2f088475af62ff9e9c418ceb055cdf95a8

review: Approve
Revision history for this message
Lee Trager (ltrager) wrote :

LGTM!

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

LANDING
-b virsh-create-vol-rework lp:~ack/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10176/consoleText

Revision history for this message
MAAS Lander (maas-lander) wrote :

LANDING
-b virsh-create-vol-rework lp:~ack/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10177/consoleText

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches