Merge lp://staging/~ack/landscape-client/vm-info-detect-qemu into lp://staging/~landscape/landscape-client/trunk

Proposed by Alberto Donato
Status: Merged
Approved by: Alberto Donato
Approved revision: 789
Merged at revision: 789
Proposed branch: lp://staging/~ack/landscape-client/vm-info-detect-qemu
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 158 lines (+80/-33)
2 files modified
landscape/lib/tests/test_vm_info.py (+23/-1)
landscape/lib/vm_info.py (+57/-32)
To merge this branch: bzr merge lp://staging/~ack/landscape-client/vm-info-detect-qemu
Reviewer Review Type Date Requested Status
Björn Tillenius (community) Approve
Free Ekanayaka (community) Approve
Review via email: mp+236314@code.staging.launchpad.net

Commit message

This extends the VM-info detection to report QEMU-virtualized machines that report "QEMU" as vendor as type "kvm".
Currently QEMU machines are only matches if they have the string "QEMU" in their /proc/cpuinfo. This isn't always the case.

Also, support for detecting Google Compute Engine (reported as vm-info "gce") has been added.

The branch also makes the match a less bit strict, by using case-insensitive match, and more generic strings.

Description of the change

This extends the VM-info detection to report QEMU-virtualized machines that report "QEMU" as vendor as type "kvm".
Currently QEMU machines are only matches if they have the string "QEMU" in their /proc/cpuinfo. This isn't always the case.

The branch also makes the match a less bit strict, by using case-insensitive match, and more generic strings.

To post a comment you must log in.
Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

I think Google is missing from the vendor list? See the bug.

review: Needs Information
789. By Alberto Donato

Add vm-info detection for Google GCE.

Revision history for this message
Alberto Donato (ack) wrote :

> I think Google is missing from the vendor list? See the bug.

Ah, thanks, I missed the comment. It's added now.

Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

+1

review: Approve
Revision history for this message
Björn Tillenius (bjornt) wrote :

Looks good, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: