Landscape Client

Merge lp://staging/~ack/landscape-client/hide-vlan-ifaces into lp://staging/~landscape/landscape-client/trunk

  1. hide-vlan-ifaces
  2. Merge into trunk
Proposed by Alberto Donato
Status: Merged
Approved by: Jerry Seutter
Approved revision: 574
Merged at revision: 573
Proposed branch: lp://staging/~ack/landscape-client/hide-vlan-ifaces
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 63 lines (+29/-2)
2 files modified
landscape/lib/network.py (+6/-1)
landscape/lib/tests/test_network.py (+23/-1)
To merge this branch: bzr merge lp://staging/~ack/landscape-client/hide-vlan-ifaces
Reviewer Review Type Date Requested Status
Jerry Seutter (community) Approve
Chris Glass (community) Approve
Review via email: mp+120737@code.staging.launchpad.net

Description of the change

Skip VLAN interfaces and interface aliases from the list of interfaces displayed by landscape-sysinfo.

To post a comment you must log in.
Revision history for this message
Chris Glass (tribaal) wrote :

Seems ok, but running "make check" makes the two new tests fail with https://pastebin.canonical.com/72788/

review: Needs Fixing
lp://staging/~ack/landscape-client/hide-vlan-ifaces updated
574. By Alberto Donato

Use passthrough on mocked call.

Revision history for this message
Chris Glass (tribaal) wrote :

Thanks for the fix, works great! +1

review: Approve
Revision history for this message
Jerry Seutter (jseutter) wrote :

+1, looks good :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: