Phablet Tools

Merge lp://staging/~achiang/phablet-tools/ubuntuimage into lp://staging/phablet-tools/ubuntuimage

  1. ubuntuimage
  2. Merge into ubuntuimage
Proposed by Alex Chiang
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 7
Merged at revision: 7
Proposed branch: lp://staging/~achiang/phablet-tools/ubuntuimage
Merge into: lp://staging/phablet-tools/ubuntuimage
Diff against target: 60 lines (+25/-10)
1 file modified
images.go (+25/-10)
To merge this branch: bzr merge lp://staging/~achiang/phablet-tools/ubuntuimage
Reviewer Review Type Date Requested Status
Sergio Schvezov Approve
Review via email: mp+199019@code.staging.launchpad.net

Description of the change

  Display download progress bar

  - Add dependency on github.com/cheggaaa/pb (BSD 3-clause)
  - Display progress bar on files larger than 2K bytes

To post a comment you must log in.
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

The only thing sort of blocking me from merging this instantly is that the code is pending a push to ubuntu archives and for this to work, I'd need to package github.com/cheggaaa/pb which I'm going to do now

Revision history for this message
Sergio Schvezov (sergiusens) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches