Merge lp://staging/~acespritech/openerp-web/6.1_bug_1006832_IntellecTSeedTechnologies into lp://staging/openerp-web/6.1
Proposed by
Acespritech Solutions Pvt. Ltd.
| Status: | Rejected | ||||
|---|---|---|---|---|---|
| Rejected by: | Xavier (Open ERP) | ||||
| Proposed branch: | lp://staging/~acespritech/openerp-web/6.1_bug_1006832_IntellecTSeedTechnologies | ||||
| Merge into: | lp://staging/openerp-web/6.1 | ||||
| Diff against target: |
17 lines (+7/-0) 1 file modified
addons/web/static/src/js/chrome.js (+7/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~acespritech/openerp-web/6.1_bug_1006832_IntellecTSeedTechnologies | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Xavier (Open ERP) (community) | Disapprove | ||
|
Review via email:
|
|||
Description of the change
Database creation error will be raised if the database already exists in the list.
To post a comment you must log in.
Revision history for this message
| Xavier (Open ERP) (xmo-deactivatedaccount) wrote | # |
review:
Disapprove
Unmerged revisions
- 2338. By Acespritech Solutions Pvt. Ltd.
-
[FIX] Fixed dynamic db name.
- 2337. By Acespritech Solutions Pvt. Ltd.
-
[FIX] Raise Database creation error if database already exists.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This code is not correct either (inArray returns −1 if it does not find, and the index of the match in all other cases, so this will work *only* if there is only one db and it matches otherwise it will never display error, test should be `!== −1`).
Rejecting this, because we'll be fixing original proposal instead.