webbrowser-app

Merge lp://staging/~abreu-alexandre/webbrowser-app/window-open-overlay into lp://staging/webbrowser-app

window-open-overlay
Merge into trunk

Proposed by Alexandre Abreu on 2015-01-29

Status:

Merged

Approved by:

Olivier Tilloy on 2015-04-30

Approved revision:

989

Merged at revision:

989

Proposed branch:

lp://staging/~abreu-alexandre/webbrowser-app/window-open-overlay

Merge into:

lp://staging/webbrowser-app

Diff against target:

1006 lines (+612/-253)

9 files modified

src/app/webcontainer/PopupWindowController.qml (+181/-0)
src/app/webcontainer/PopupWindowOverlay.qml (+199/-0)
src/app/webcontainer/WebViewImplOxide.qml (+13/-130)
src/app/webcontainer/WebappContainerWebview.qml (+11/-1)
tests/autopilot/webapp_container/tests/__init__.py (+6/-0)
tests/autopilot/webapp_container/tests/fake_servers.py (+32/-11)
tests/autopilot/webapp_container/tests/test_popup_webview_overlay.py (+170/-0)
tests/autopilot/webapp_container/tests/test_redirection_pattern.py (+0/-59)
tests/autopilot/webapp_container/tests/test_url_patterns.py (+0/-52)

To merge this branch:

bzr merge lp://staging/~abreu-alexandre/webbrowser-app/window-open-overlay

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Olivier Tilloy		2015-01-29	Approve on 2015-04-30
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-04-30
Review via email: mp+248000@code.staging.launchpad.net

Commit message

Add multi-window support for webapps

Description of the change

Add multi-window support for webapps

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-23:

FAILED: Continuous integration, rev:943
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1552/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1930/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/310/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/310/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/310/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1928/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1552/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-24:

FAILED: Continuous integration, rev:944
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1555/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1935/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/313/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/313/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/313/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1933/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1555/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-24:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1558/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-24:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1562/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Olivier Tilloy (osomon) wrote on 2015-03-27:

Not sure exactly what the intended UX behaviour is (the spec is a bit summary), this is what I’m seeing when testing on the desktop:

- The animation to open an overlay is quite fast, almost imperceptible (could we maybe make it a tad slower?)

- When dismissing an overlay (by dragging it downwards or clicking on the chevron), it’s destroyed, right? I’m thinking that in that case maybe a cross icon would be more appropriate than a chevron, but of course that’s for a visual designer to decide.

- When opening an overlay, the current webview seems to be hidden instantaneously, it should be hidden only once the animation has completed.

- Similarly, when dragging an overlay downwards, nothing is visible behind, I think the main webview (or the previous overlay if any) should be visible.

- After opening 3 overlays, the fourth external link gets open in my desktop browser (chromium) as expected, but then after closing one overlay and starting to re-open more external links, I got in a situation where blank chromium windows would open instead of a new tab in the current instance, this is weird (tested with initially opening the container on http://plus.google.com). When that happens, I’m seeing the following message on the console:

qml: Maximum number of popup overlay opened, opening: about:blank in the browser

Revision history for this message

Olivier Tilloy (osomon) wrote on 2015-03-27:

Also, I’m thinking that this behaviour makes sense on devices, but does it on desktop, where it’s much more visible when a new tab opens in a browser?

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-27:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1584/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~abreu-alexandre/webbrowser-app/window-open-overlay updated on 2015-03-31

948. By Launchpad Translations on behalf of phablet-team on 2015-03-31: Launchpad automatic translations update.

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2015-03-31:

> Not sure exactly what the intended UX behaviour is (the spec is a bit
> summary), this is what I’m seeing when testing on the desktop:
>
> - The animation to open an overlay is quite fast, almost imperceptible (could
> we maybe make it a tad slower?)

agree, done

> - When dismissing an overlay (by dragging it downwards or clicking on the
> chevron), it’s destroyed, right? I’m thinking that in that case maybe a cross
> icon would be more appropriate than a chevron, but of course that’s for a
> visual designer to decide.

yeah, those are the designs I had from "design", ... imo it is rather understandable,

> - When opening an overlay, the current webview seems to be hidden
> instantaneously, it should be hidden only once the animation has completed.
>
> - Similarly, when dragging an overlay downwards, nothing is visible behind, I
> think the main webview (or the previous overlay if any) should be visible.

I updated the behavior to be cleaner & slicker,

> - After opening 3 overlays, the fourth external link gets open in my desktop
> browser (chromium) as expected, but then after closing one overlay and
> starting to re-open more external links, I got in a situation where blank
> chromium windows would open instead of a new tab in the current instance, this
> is weird (tested with initially opening the container on
> http://plus.google.com). When that happens, I’m seeing the following message
> on the console:
>
> qml: Maximum number of popup overlay opened, opening: about:blank in the
> browser

mmh I was not able to repro that ...

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2015-03-31:

> Also, I’m thinking that this behaviour makes sense on devices, but does it on
> desktop, where it’s much more visible when a new tab opens in a browser?

I would have to check with design, but I still does make sense on desktop too.
The behavior might be adjusted a bit but it does not feel too awkward.

We dont support tabs for webapps no matter what the environment is, and when thinking
about tabs+webapps on desktop it is not obvious to me how to have it work in a clean way
for the user. Adding tabs is somewhat out of the question (at least atm) I think,

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-31:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1596/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~abreu-alexandre/webbrowser-app/window-open-overlay updated on 2015-04-15

949. By Olivier Tilloy on 2015-03-31

Use the new locationBarController API available in oxide 1.5 to control the position of the chrome. Fixes: #1365179, #1429132
Approved by: Alexandre Abreu

950. By Olivier Tilloy on 2015-03-31

Rewrite URLs with an uppercase scheme. Fixes: #1436312

951. By Olivier Tilloy on 2015-03-31

Remove two broken symlinks.

952. By Olivier Tilloy on 2015-03-31

Always initialize member attribute at construction time.

Not really an issue here, but flagged by coverity (https://scan.coverity.com/projects/4565), and easy enough to address.

953. By CI Train Bot Account on 2015-03-31

Releasing 0.23+15.04.20150331.2-0ubuntu1

954. By CI Train Bot Account on 2015-04-07

Resync trunk.

955. By Launchpad Translations on behalf of phablet-team on 2015-04-07

Launchpad automatic translations update.

956. By Riccardo Padovani on 2015-04-08

Add settings page, per design specification. This adds qml-module-qt-labs-folderlistmodel and qml-module-qt-labs-settings as runtime dependencies for webbrowser-app. Fixes: #1351183
Approved by: Bill Filler, Olivier Tilloy

957. By Olivier Tilloy on 2015-04-08

Autopilot tests for the settings UI.

958. By Olivier Tilloy on 2015-04-08

Add a "Clear Cache" entry under the privacy settings. Fixes: #1260014, #1296364
Approved by: PS Jenkins bot

959. By CI Train Bot Account on 2015-04-08

Releasing 0.23+15.04.20150408-0ubuntu1

960. By Olivier Tilloy on 2015-04-08

Update translation template.

961. By Launchpad Translations on behalf of phablet-team on 2015-04-09

Launchpad automatic translations update.

962. By Launchpad Translations on behalf of phablet-team on 2015-04-10

Launchpad automatic translations update.

963. By Alexandre Abreu on 2015-04-10

remove qtwebkit deps (LP: #1362640) Fixes: #1362640
Approved by: Timo Jyrinki, PS Jenkins bot, Olivier Tilloy

964. By Justin McPherson <justin@phablet-dev> on 2015-04-10

Command line options for media-hub use through Oxide.
Approved by: PS Jenkins bot

965. By CI Train Bot Account on 2015-04-10

Releasing 0.23+15.04.20150410-0ubuntu1

966. By CI Train Bot Account on 2015-04-14

Resync trunk.

967. By Launchpad Translations on behalf of phablet-team on 2015-04-15

Launchpad automatic translations update.

Revision history for this message

Olivier Tilloy (osomon) wrote on 2015-04-20:

There’s a couple of trivial conflicts when merging into the latest trunk.

review: Needs Fixing

Revision history for this message

Olivier Tilloy (osomon) wrote on 2015-04-20:

I’m seeing 3 failures when running the autopilot tests on my desktop:

    webapp_container.tests.test_popup_webview_overlay.WebappContainerPopupWebViewOverlayTestCase.test_max_overlay_count_reached
    webapp_container.tests.test_popup_webview_overlay.WebappContainerPopupWebViewOverlayTestCase.test_open_close_back_to_mainview
    webapp_container.tests.test_popup_webview_overlay.WebappContainerPopupWebViewOverlayTestCase.test_open_overlay_in_main_browser

review: Needs Fixing

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2015-04-21:

updated

lp://staging/~abreu-alexandre/webbrowser-app/window-open-overlay updated on 2015-04-21

968. By Arthur Mello on 2015-04-16: Add model support to control which history entries will be displayed based on a blacklist database
Approved by: PS Jenkins bot, Olivier Tilloy
969. By Arthur Mello on 2015-04-16: Make Top Sites format equal to Bookmarks on the New Tab view
Approved by: PS Jenkins bot
970. By CI Train Bot Account on 2015-04-16: Releasing 0.23+15.04.20150416-0ubuntu1

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-04-21:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1674/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~abreu-alexandre/webbrowser-app/window-open-overlay updated on 2015-04-22

971. By CI Train Bot Account on 2015-04-21: Resync trunk.
972. By Launchpad Translations on behalf of phablet-team on 2015-04-22: Launchpad automatic translations update.

Revision history for this message

Olivier Tilloy (osomon) wrote on 2015-04-24:

I’m still seeing autopilot test failures when run on my desktop (up-to-date vivid): http://pastebin.ubuntu.com/10879666/

review: Needs Fixing

lp://staging/~abreu-alexandre/webbrowser-app/window-open-overlay updated on 2015-04-24

973. By Ugo Riboni on 2015-04-22

Include bookmark results in the suggestions list Fixes: #1351177
Approved by: Olivier Tilloy, PS Jenkins bot

974. By Alexandre Abreu on 2015-04-22

Add missing reload button from the webapp container as specified in the design document.
Approved by: Olivier Tilloy, PS Jenkins bot

975. By Ken VanDine on 2015-04-22

added ShareLink to contextualActions

Approved by: Olivier Tilloy, PS Jenkins bot

976. By Olivier Tilloy on 2015-04-22

Save the updated homepage when pressing return. Fixes: #1441874
Approved by: PS Jenkins bot, Riccardo Padovani

977. By Leo Arias on 2015-04-22

In the autopilot tests, removed the extra focus step to write a URL. Fixes: #1441551
Approved by: Olivier Tilloy, PS Jenkins bot

978. By Olivier Tilloy on 2015-04-22

Always exit fullscreen mode when the application becomes inactive. Fixes: #1331475
Approved by: PS Jenkins bot, Bill Filler

979. By Olivier Tilloy on 2015-04-22

Recognize about:blank as a valid URL. Fixes: #1444139
Approved by: PS Jenkins bot

980. By CI Train Bot Account on 2015-04-22

Releasing 0.23+15.04.20150422.1-0ubuntu1

981. By CI Train Bot Account on 2015-04-24

Resync trunk.

982. By Olivier Tilloy on 2015-04-24

Update translation template.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-04-24:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1685/rebuild

review: Approve (continuous-integration)

lp://staging/~abreu-alexandre/webbrowser-app/window-open-overlay updated on 2015-04-29

983. By Launchpad Translations on behalf of phablet-team on 2015-04-25: Launchpad automatic translations update.
984. By Launchpad Translations on behalf of phablet-team on 2015-04-26: Launchpad automatic translations update.
985. By Launchpad Translations on behalf of phablet-team on 2015-04-27: Launchpad automatic translations update.
986. By Launchpad Translations on behalf of phablet-team on 2015-04-28: Launchpad automatic translations update.
987. By Launchpad Translations on behalf of phablet-team on 2015-04-29: Launchpad automatic translations update.
988. By Alexandre Abreu on 2015-04-29: Window overlay for popups
989. By Alexandre Abreu on 2015-04-29: Fix AP global coords used for the clicks