Merge lp://staging/~abreu-alexandre/webbrowser-app/webapp-properties-ua-override-fix-rtm-14.09 into lp://staging/webbrowser-app/rtm-14.09

Proposed by Alexandre Abreu
Status: Rejected
Rejected by: Olivier Tilloy
Proposed branch: lp://staging/~abreu-alexandre/webbrowser-app/webapp-properties-ua-override-fix-rtm-14.09
Merge into: lp://staging/webbrowser-app/rtm-14.09
Diff against target: 67 lines (+12/-13)
2 files modified
src/app/webcontainer/WebApp.qml (+1/-12)
src/app/webcontainer/webapp-container.qml (+11/-1)
To merge this branch: bzr merge lp://staging/~abreu-alexandre/webbrowser-app/webapp-properties-ua-override-fix-rtm-14.09
Reviewer Review Type Date Requested Status
Olivier Tilloy Disapprove
Review via email: mp+243834@code.staging.launchpad.net

Commit message

A Webapp has the option to either specify a command line option to have a specific UA overriding the default or hgave a local webapp-properties.json file that defines the UA override such as:

{
    "name": "MyWebapp",
    "includes":["http://user-agent.me/*"],
    "domain":"user-agent.me",
    "homepage":"http://user-agent.me/",
    "user-agent-override": "Mozilla/5.0 custom-user-agent-string (unlike AnyOtheBrowser)"
}

This currently does not work, or to be more precise works but the url is set before during the init flow, and the UA string is being set after the website was browsed to.

Description of the change

Backport of

https://code.launchpad.net/~abreu-alexandre/webbrowser-app/fix-webapp-properties-ua-override/+merge/238991

Here is the description of the MR replicated:

"A Webapp has the option to either specify a command line option to have a specific UA overriding the default or hgave a local webapp-properties.json file that defines the UA override such as:

{
    "name": "MyWebapp",
    "includes":["http://user-agent.me/*"],
    "domain":"user-agent.me",
    "homepage":"http://user-agent.me/",
    "user-agent-override": "Mozilla/5.0 custom-user-agent-string (unlike AnyOtheBrowser)"
}

This currently does not work, or to be more precise works but the url is set before during the init flow, and the UA string is being set after the website was browsed to."

To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

Not needed any longer, as the entire trunk was backported to RTM.

review: Disapprove

Unmerged revisions

777. By Alexandre Abreu

BAckport webapp-properties.json UA override fix to RTM

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches