webbrowser-app

Merge lp://staging/~abreu-alexandre/webbrowser-app/fix-url-updates-for-manifest-webapps into lp://staging/webbrowser-app

  1. fix-url-updates-for-manifest-webapps
  2. Merge into trunk
Proposed by Alexandre Abreu
Status: Work in progress
Proposed branch: lp://staging/~abreu-alexandre/webbrowser-app/fix-url-updates-for-manifest-webapps
Merge into: lp://staging/webbrowser-app
Diff against target: 18 lines (+7/-1)
1 file modified
src/app/webcontainer/WebViewImplOxide.qml (+7/-1)
To merge this branch: bzr merge lp://staging/~abreu-alexandre/webbrowser-app/fix-url-updates-for-manifest-webapps
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Olivier Tilloy Needs Fixing
Review via email: mp+276413@code.staging.launchpad.net

Commit message

Fix URL update for webapps that are based on local manifest.json files. The update is done no matter what overriding any other potential url currently being browsed to.

Description of the change

Fix URL update for webapps that are based on local manifest.json files. The update is done no matter what overriding any other potential url currently being browsed to.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1262
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2429/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4978
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1183
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1183
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1183/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1183
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3997
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4975
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4975/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24816

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2429/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Olivier Tilloy (osomon) wrote :

This change breaks 3 existing autopilot tests.

review: Needs Fixing
Reply
lp://staging/~abreu-alexandre/webbrowser-app/fix-url-updates-for-manifest-webapps updated
1263. By Alexandre Abreu

updated

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

updated

Reply
Revision history for this message
Olivier Tilloy (osomon) wrote :

I’m not familiar with this code, and I’m not sure how to verify that it actually fixes the bug, but at least the autopilot tests all pass on my desktop.

Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1263
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2456/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5100
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1210
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1210
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1210/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1210
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4082
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5107
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5107/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25042

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2456/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

I updated the TEstPlan to account for those uri-handler tests:

https://wiki.ubuntu.com/Process/Merges/TestPlan/webapp-container

I will update the MR though with tests for that since the matrix of tests is not getting simpler to cover all the cases, it'll be better if automated

Reply

Unmerged revisions

1263. By Alexandre Abreu

updated

1262. By Alexandre Abreu

Fix url updates

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: