webbrowser-app

Merge lp://staging/~abreu-alexandre/webbrowser-app/fix-invalid-variable-popupWindowController-access into lp://staging/webbrowser-app

  1. fix-invalid-variable-popupWindowController-access
  2. Merge into trunk
Proposed by Alexandre Abreu
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 1429
Merged at revision: 1430
Proposed branch: lp://staging/~abreu-alexandre/webbrowser-app/fix-invalid-variable-popupWindowController-access
Merge into: lp://staging/webbrowser-app
Diff against target: 180 lines (+64/-3)
7 files modified
src/app/webcontainer/WebApp.qml (+1/-0)
src/app/webcontainer/WebViewImplOxide.qml (+5/-2)
src/app/webcontainer/WebappContainerWebview.qml (+3/-1)
src/app/webcontainer/webapp-container.cpp (+5/-0)
src/app/webcontainer/webapp-container.qml (+2/-0)
tests/autopilot/webapp_container/tests/fake_servers.py (+29/-0)
tests/autopilot/webapp_container/tests/test_popup_webview_overlay.py (+19/-0)
To merge this branch: bzr merge lp://staging/~abreu-alexandre/webbrowser-app/fix-invalid-variable-popupWindowController-access
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+292419@code.staging.launchpad.net

Commit message

Fix invalid variable reference popupWindowController

Description of the change

Fix invalid variable reference popupWindowController,

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1427
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2701/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6850/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1454/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1454/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1454/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6861/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2701/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~abreu-alexandre/webbrowser-app/fix-invalid-variable-popupWindowController-access updated
1428. By Alexandre Abreu

Fix typo in navigation handling of overlays

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1428
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2705/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6869/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1458/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1458/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1458/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6880/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2705/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~abreu-alexandre/webbrowser-app/fix-invalid-variable-popupWindowController-access updated
1429. By Alexandre Abreu

remove debug comment

Revision history for this message
Alberto Mardegan (mardy) wrote :

LGTM!

review: Approve
lp://staging/~abreu-alexandre/webbrowser-app/fix-invalid-variable-popupWindowController-access updated
1430. By Alexandre Abreu

fix flake8

1431. By Alexandre Abreu

qEnvironmentVariableIntValue is not avail in pre-5.5 versions of Qt

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: