webbrowser-app

Merge lp://staging/~abreu-alexandre/webbrowser-app/context-menu-to-overlay-webviews into lp://staging/webbrowser-app

  1. context-menu-to-overlay-webviews
  2. Merge into trunk
Proposed by Alexandre Abreu
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 1372
Merged at revision: 1376
Proposed branch: lp://staging/~abreu-alexandre/webbrowser-app/context-menu-to-overlay-webviews
Merge into: lp://staging/webbrowser-app
Diff against target: 969 lines (+463/-188)
14 files modified
src/app/ContentHandler.qml (+1/-1)
src/app/webbrowser/Browser.qml (+1/-1)
src/app/webbrowser/ContentDownloadDialog.qml (+1/-0)
src/app/webbrowser/ContentPickerDialog.qml (+1/-0)
src/app/webbrowser/DownloadsPage.qml (+1/-0)
src/app/webcontainer/ContentDownloadDialog.qml (+1/-0)
src/app/webcontainer/ContentPickerDialog.qml (+1/-0)
src/app/webcontainer/PopupWindowController.qml (+3/-0)
src/app/webcontainer/PopupWindowOverlay.qml (+9/-2)
src/app/webcontainer/WebViewImplOxide.qml (+3/-138)
src/app/webcontainer/WebappContainerWebview.qml (+7/-1)
src/app/webcontainer/WebappWebview.qml (+234/-0)
tests/autopilot/webapp_container/tests/fake_servers.py (+10/-4)
tests/autopilot/webapp_container/tests/test_context_menu.py (+190/-41)
To merge this branch: bzr merge lp://staging/~abreu-alexandre/webbrowser-app/context-menu-to-overlay-webviews
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
Alberto Mardegan (community) Approve
David Barth (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+282489@code.staging.launchpad.net

Commit message

Handle context menu in overlay webviews.

Description of the change

Handle context menu in overlay webviews.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1324
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2592/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6255/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1345/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1345/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1345/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6266/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2592/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1325
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2600/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6315
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1353
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1353
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1353/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1353
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4852
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6326
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6326/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27275

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2600/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

A couple of minor inline comments.

review: Needs Fixing
Revision history for this message
David Barth (dbarth) :
review: Approve
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

Sorry Alberto I seem to have missed your inline comments, the branch has been updated

Revision history for this message
Alberto Mardegan (mardy) wrote :

LGTM!

review: Approve
Revision history for this message
Olivier Tilloy (osomon) wrote :

The copyright year in the header for src/app/webcontainer/WebappWebview.qml should be 2016.

It would be good to add autopilot tests to verify that the menu also works in overlays.

The changes otherwise look good (and I’ve verified they don’t introduce regressions in the browser).

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> The copyright year in the header for src/app/webcontainer/WebappWebview.qml
> should be 2016.

done

>
> It would be good to add autopilot tests to verify that the menu also works in
> overlays.

done

Revision history for this message
Olivier Tilloy (osomon) wrote :

There are multiple flake8 errors in the changed python files.

review: Needs Fixing
Revision history for this message
Olivier Tilloy (osomon) wrote :

LGTM now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: