Merge into trunk : container-extension : Code : webbrowser-app

Reviewer	Review Type	Date Requested	Status
system-apps-ci-bot	continuous-integration		Needs Fixing on 2016-07-13
Alberto Mardegan (community)		2015-11-27	Approve on 2016-01-29
PS Jenkins bot	continuous-integration		Needs Fixing on 2016-01-28
Review via email: mp+278870@code.staging.launchpad.net

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-15:

#

FAILED: Continuous integration, rev:1285
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2534/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5797/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1288/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1288/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1288/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5810/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2534/rebuild

review: Needs Fixing (continuous-integration)

Reply

lp://staging/~abreu-alexandre/webbrowser-app/container-extension updated on 2015-12-18

1298. By Zsombor Egri on 2015-12-18: Fix local Toolbar collision with UITK 1.3 Toolbar.
Approved by: Olivier Tilloy, Zoltan Balogh
1299. By Olivier Tilloy on 2015-12-18: Work around what appears to be a regression in the UITK by specifying a non-null delay when swiping a list item to delete it in unit tests. Fixes: #1526940
Approved by: Michael Sheldon
1300. By CI Train Bot Account on 2015-12-18: Releasing 0.23+16.04.20151218-0ubuntu1

Revision history for this message

Alberto Mardegan (mardy) wrote on 2015-12-18:

#

Please document what translateHandlerUri() and translateUri() do, because otherwise it's very difficult to understand what is happening here :-)

Reply

lp://staging/~abreu-alexandre/webbrowser-app/container-extension updated on 2016-01-12

1301. By Michael Sheldon on 2015-12-21: Add support for handling downloads internally within the browser. Fixes: #1354391
Approved by: Olivier Tilloy
1302. By CI Train Bot Account on 2015-12-21: Releasing 0.23+16.04.20151221-0ubuntu1
1303. By Olivier Tilloy on 2015-12-22: Update translation template.
1304. By Olivier Tilloy on 2015-12-22: Recognize openoffice and MS-office file formats as documents, now that the document viewer app knows how to render them. Fixes: #1523452
Approved by: Michael Sheldon, PS Jenkins bot
1305. By Olivier Tilloy on 2015-12-22: Do not allow interacting with tabs and the chrome while the settings page is shown. Fixes: #1524353
Approved by: PS Jenkins bot, Ugo Riboni
1306. By Olivier Tilloy on 2015-12-22: Use the screen size (diagonal in millimeters) to determine which default UA string and which UA overrides to use.
An empirical threshold of 19cm is being used, it is subject to further adjustments. Fixes: #1504084
Approved by: PS Jenkins bot
1307. By Olivier Tilloy on 2015-12-22: Add keyboard shorcuts for 'next' (Ctrl+G) and 'previous' (Ctrl+Shift+G) while in find-in-page mode. Fixes: #1522152
Approved by: PS Jenkins bot, Ugo Riboni
1308. By Olivier Tilloy on 2015-12-22: Fix the tab preview sometimes covering the tab chrome, in the tabs view.
Offset tab previews by 1px to cover the semi-transparent horizontal line at the bottom of the tab chrome asset. Fixes: #1520624
Approved by: PS Jenkins bot, Ugo Riboni
1309. By Olivier Tilloy on 2015-12-22: Fix some obvious issues in PreviewManager. Fixes: #1519019
Approved by: PS Jenkins bot, Ugo Riboni
1310. By Olivier Tilloy on 2015-12-22: Fix a crash when clearing the navigation history while the new tab view is open. Fixes: #1525937
Approved by: Ugo Riboni
1311. By Olivier Tilloy on 2015-12-22: Fix deleting multiple domains from the history view.
Add unit tests for the HistoryView component. Fixes: #1527144
1312. By CI Train Bot Account on 2015-12-22: Releasing 0.23+16.04.20151222.1-0ubuntu1
1313. By CI Train Bot Account on 2016-01-05: Resync trunk.
1314. By Launchpad Translations on behalf of phablet-team on 2016-01-06: Launchpad automatic translations update.
1315. By Alexandre Abreu on 2016-01-06: Make the webapp-container click hook more flexible. Instead of being able to delete cache & resource folders as the click is being uninstalled, one can also act on them as the click is being upgraded & installed. Fixes: #1522562
Approved by: PS Jenkins bot, Alberto Mardegan
1316. By Alexandre Abreu on 2016-01-06: Handle empty url pattern in configuration file and invalid url pattern being specified. Fixes: #1522585
Approved by: PS Jenkins bot, Alberto Mardegan
1317. By Alexandre Abreu on 2016-01-06: Handle application crashes or OOM interventions & save opened overlays Fixes: #1508969
Approved by: PS Jenkins bot, Alberto Mardegan
1318. By Alexandre Abreu on 2016-01-06: Limited handling of custom context menu for the container
Approved by: Alberto Mardegan
1319. By CI Train Bot Account on 2016-01-06: Releasing 0.23+16.04.20160106.4-0ubuntu1
1320. By Alexandre Abreu on 2016-01-08: Handle theme_color page metainformation. Fixes: #1477674
Approved by: Alberto Mardegan
1321. By CI Train Bot Account on 2016-01-08: Releasing 0.23+16.04.20160108.1-0ubuntu1
1322. By CI Train Bot Account on 2016-01-11: Resync trunk.
1323. By Launchpad Translations on behalf of phablet-team on 2016-01-12: Launchpad automatic translations update.
1324. By Olivier Tilloy on 2016-01-12: Restore active focus on the webview after closing the context menu. Fixes: #1526884
Approved by: Bill Filler
1325. By Michael Sheldon on 2016-01-12: Dynamically load the thumbnailer image provider if it's available, otherwise fallback to mimetype images Fixes: #1531179
Approved by: Olivier Tilloy
1326. By Olivier Tilloy on 2016-01-12: Address a number of minor functional and code issues in the new downloads-in-browser functionality. Fixes: #1528651
Approved by: Michael Sheldon
1327. By CI Train Bot Account on 2016-01-12: Releasing 0.23+16.04.20160112.1-0ubuntu1

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-13:

#

FAILED: Continuous integration, rev:1286
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2560/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6014/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1313/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1313/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1313/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6025/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2560/rebuild

review: Needs Fixing (continuous-integration)

Reply

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2016-01-13:

#

> Please document what translateHandlerUri() and translateUri() do, because
> otherwise it's very difficult to understand what is happening here :-)

I updated the branch with some documentation

Reply

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-13:

#

FAILED: Continuous integration, rev:1287
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2561/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6018/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1314/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1314/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1314/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6029/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2561/rebuild

review: Needs Fixing (continuous-integration)

Reply

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-14:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2563/rebuild

review: Needs Fixing (continuous-integration)

Reply

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-14:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2564/rebuild

review: Needs Fixing (continuous-integration)

Reply

Revision history for this message

Alberto Mardegan (mardy) wrote on 2016-01-18:

#

Thanks for the explanations. I've added a few more inline comments, and here are two generic remarks:

1) You should document somewhere the list of hooks that can be intercepted by the webapp script. Some king of a readme where we document the hook names, their parameters and return values.

2) I really don't like using a Loader in order to load the script: a Loader is used to use a QQuick item, while what we really need is a JS object (also, using a Loader makes the loading of the webview even more complex). I haven't researched this in depth, and indeed it may be that QML doesn't offer much in terms of dynamically loading .js files. At a first sight, it looks like QJSEngine::evaluate() could be a good option: in webcontainer.cpp you could check if the webapp ships a .js file, load it, let the QQmlEngine (which is a subclass of QJSEngine) evaluate it and then set the returned QJSValue as a property of the main QML file we load:
http://doc.qt.io/qt-5/qjsengine.html#evaluate
I never did anything similar, but I believe that it should work.

review: Needs Fixing

Reply

lp://staging/~abreu-alexandre/webbrowser-app/container-extension updated on 2016-01-22

1328. By Launchpad Translations on behalf of phablet-team on 2016-01-21: Launchpad automatic translations update.
1329. By Launchpad Translations on behalf of phablet-team on 2016-01-22: Launchpad automatic translations update.
1330. By Olivier Tilloy on 2016-01-22: Fix failing autopilot test.
With recent changes in the UITK, swiping a non-swipeable item to the right activates it. Fixes: #1534139
1331. By Olivier Tilloy on 2016-01-22: Automatically focus the address bar when opening a new tab in wide mode (instead of inferring a "desktop" form factor).
This is not exactly the correct fix (which would require the QInputInfo API), but is better than the current situation anyway. Fixes: #1533317
1332. By Olivier Tilloy on 2016-01-22: Show the share action if Ubuntu.Content is available, regardless of the form factor.
1333. By Olivier Tilloy on 2016-01-22: Fix undefined reference when dragging a bookmark from one folder to another one.
1334. By Olivier Tilloy on 2016-01-22: Ensure that only one instance of the app is running. Fixes: #1535199
Approved by: Alexandre Abreu
1335. By CI Train Bot Account on 2016-01-22: Releasing 0.23+16.04.20160122-0ubuntu1

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2016-01-22:

#

> Thanks for the explanations. I've added a few more inline comments

see my comments inline (I updated most)

> , and here
> are two generic remarks:
>
> 1) You should document somewhere the list of hooks that can be intercepted by
> the webapp script. Some king of a readme where we document the hook names,
> their parameters and return values.

agree, done (not as a readme though)

> 2) I really don't like using a Loader in order to load the script: a Loader is
> used to use a QQuick item, while what we really need is a JS object (also,
> using a Loader makes the loading of the webview even more complex). I haven't
> researched this in depth, and indeed it may be that QML doesn't offer much in
> terms of dynamically loading .js files. At a first sight, it looks like
> QJSEngine::evaluate() could be a good option: in webcontainer.cpp you could
> check if the webapp ships a .js file, load it, let the QQmlEngine (which is a
> subclass of QJSEngine) evaluate it and then set the returned QJSValue as a
> property of the main QML file we load:
> http://doc.qt.io/qt-5/qjsengine.html#evaluate
> I never did anything similar, but I believe that it should work.

yes it would work this is what I do for URI filtering code (see comment) in scheme-filter.cpp.

But for this extension mechanism part, I wanted something simpler maybe and more
flexible than plain QJSEngine ... If one wanted to put a bit more logic in
the 'extension', and possibly have more than one file which is not possible with
QJSEngine (import does not work).

WDYT?

Reply

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-22:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2573/rebuild

review: Needs Fixing (continuous-integration)

Reply

Revision history for this message

Alberto Mardegan (mardy) wrote on 2016-01-25:

#

Thanks for the update. I didn't know of the QJSEngine limitation about "import" not working; I would still prefer to go through that route, and eventually reconsider it if/when it turns out we really need "import" to work (and who knows, maybe QJSEngine will have support for it by then).

However, I'm not going to block the review on this, if you disagree.

Reply

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2016-01-27:

#

> Thanks for the update. I didn't know of the QJSEngine limitation about
> "import" not working; I would still prefer to go through that route, and
> eventually reconsider it if/when it turns out we really need "import" to work
> (and who knows, maybe QJSEngine will have support for it by then).
>
> However, I'm not going to block the review on this, if you disagree.

well this is a discussion :)

I thought about it and the idea behind the extension option really fits the qml land.
It is not only a pure js bit (although it is in the example), it should have the option
to talk back and forth with the webview and possibly create qml elements of its own
which is not really possible (or with some painful crafted code which would in the end
look simpler with plain qml loading),

wdyt?

would it be better if I used a synchronised Qt.createQmlObject('<with source>') instead
to remove the Loader bit?

Reply

Revision history for this message

Alberto Mardegan (mardy) wrote on 2016-01-28:

#

> would it be better if I used a synchronised Qt.createQmlObject('<with
> source>') instead
> to remove the Loader bit?

This looks like a good compromise: it allows the extension to live in the QML word, and doesn't suggest that we want the extension to return something visible.

Reply

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2016-01-28:

#

> > would it be better if I used a synchronised Qt.createQmlObject('<with
> > source>') instead
> > to remove the Loader bit?
>
> This looks like a good compromise: it allows the extension to live in the QML
> word, and doesn't suggest that we want the extension to return something
> visible.

I updated the branch

Reply

Revision history for this message

Alberto Mardegan (mardy) wrote on 2016-01-28:

#

There's a merge conflict, but the new code looks fine, thanks!

Reply

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-28:

#

FAILED: Continuous integration, rev:1291
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2585/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6244/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1338/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1338/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1338/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6255/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2585/rebuild

review: Needs Fixing (continuous-integration)

Reply

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-28:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2588/rebuild

review: Needs Fixing (continuous-integration)

Reply

Revision history for this message

Alberto Mardegan (mardy) on 2016-01-29:

#

review: Approve

Reply

lp://staging/~abreu-alexandre/webbrowser-app/container-extension updated on 2016-05-04

1336. By Olivier Tilloy on 2016-01-29: Add a UA override for desktop gmail to get rid of a misleading warning about using a deprecated version of safari. Fixes: #1452616
Approved by: Alexandre Abreu
1337. By Olivier Tilloy on 2016-01-29: Update tab visuals to higher-contrast assets. Fixes: #1534760
1338. By Olivier Tilloy on 2016-01-29: Do not connect to the loadingChanged signal, which has been deprecated for a good while. Fixes: #1538190
Approved by: Alexandre Abreu
1339. By Olivier Tilloy on 2016-01-29: In narrow mode, when a mouse is connected, turn the bottom edge hint into a clickable bottom edge bar. Fixes: #1534239
Approved by: Jamie Strandboge
1340. By Olivier Tilloy on 2016-01-29: Update focus highlight to match the upcoming UITK implementation. Fixes: #1539176
1341. By CI Train Bot Account on 2016-01-29: Releasing 0.23+16.04.20160129.1-0ubuntu1
1342. By CI Train Bot Account on 2016-02-01: Resync trunk.
1343. By Launchpad Translations on behalf of phablet-team on 2016-02-02: Launchpad automatic translations update.
1344. By Alexandre Abreu on 2016-02-02: Enhance google.com specific patterns to enable co.* & com.* patterns
Fixes: #1517527
Approved by: PS Jenkins bot, Olivier Tilloy
1345. By Alexandre Abreu on 2016-02-02: Make sure that the overlay views closed by the user are not part of the list of recovered overlays opened after the oom closed the app. Fixes: #1535154
Approved by: Alberto Mardegan
1346. By CI Train Bot Account on 2016-02-02: Releasing 0.23+16.04.20160202-0ubuntu1
1347. By CI Train Bot Account on 2016-02-15: Resync trunk.
1348. By Olivier Tilloy on 2016-02-15: Add video-specific contextual actions. Fixes: #1539676
1349. By Olivier Tilloy on 2016-02-15: Use the new bottom edge bar to open the tabs view in autopilot tests.
1350. By Olivier Tilloy on 2016-02-15: Add keyboard navigation support to narrow views (new tab view, history view, bookmarks view, downloads view). Fixes: #1539221
1351. By Olivier Tilloy on 2016-02-15: Take a capture of the current page shortly after it has finished loading to give rendering an opportunity to complete. Fixes: #1540129
1352. By CI Train Bot Account on 2016-02-15: Releasing 0.23+16.04.20160215.1-0ubuntu1
1353. By CI Train Bot Account on 2016-02-16: Resync trunk.
1354. By Olivier Tilloy on 2016-02-16: Update translation template.
1355. By Launchpad Translations on behalf of phablet-team on 2016-02-17: Launchpad automatic translations update.
1356. By Launchpad Translations on behalf of phablet-team on 2016-02-18: Launchpad automatic translations update.
1357. By Launchpad Translations on behalf of phablet-team on 2016-02-19: Launchpad automatic translations update.
1358. By Launchpad Translations on behalf of phablet-team on 2016-02-20: Launchpad automatic translations update.
1359. By Launchpad Translations on behalf of phablet-team on 2016-02-21: Launchpad automatic translations update.
1360. By Launchpad Translations on behalf of phablet-team on 2016-02-23: Launchpad automatic translations update.
1361. By Olivier Tilloy on 2016-02-23: Remove the 'formFactor' context property, and replace all its uses by more meaningful conditions. Fixes: #1446904, #1542375
1362. By Olivier Tilloy on 2016-02-23: Work around bug #1546677 (UITK), by destroying the bookmark options popover instead of hiding it. Fixes: #1546627, #1546677
1363. By Olivier Tilloy on 2016-02-23: Work around a bug in the UITK that prevents touch scrolling to the left of the address bar by ensuring that the x coordinate of the text field is an integer. Fixes: #1546346
1364. By CI Train Bot Account on 2016-02-23: Releasing 0.23+16.04.20160223-0ubuntu1
1365. By CI Train Bot Account on 2016-02-25: Resync trunk.
1366. By Olivier Tilloy on 2016-02-25: Update translation template.
1367. By Launchpad Translations on behalf of phablet-team on 2016-02-26: Launchpad automatic translations update.
1368. By Launchpad Translations on behalf of phablet-team on 2016-02-28: Launchpad automatic translations update.
1369. By Launchpad Translations on behalf of phablet-team on 2016-03-01: Launchpad automatic translations update.
1370. By Olivier Tilloy on 2016-03-03: Refer to @{XDG_DOWNLOAD_DIR} in the browser’s apparmor profile instead of hardcoding "Downloads" in English. Fixes: #1535666
Approved by: Jamie Strandboge
1371. By Olivier Tilloy on 2016-03-03: Visual tweaks per designers’ review.
1372. By Olivier Tilloy on 2016-03-03: Store entries in the history database on load committed, not load succeeded.
This ensures that content-initiated navigations are also stored. Fixes: #1455858, #1549780
Approved by: Riccardo Padovani
1373. By CI Train Bot Account on 2016-03-03: Releasing 0.23+16.04.20160303-0ubuntu1
1374. By Launchpad Translations on behalf of phablet-team on 2016-03-05: Launchpad automatic translations update.
1375. By Launchpad Translations on behalf of phablet-team on 2016-03-06: Launchpad automatic translations update.
1376. By Alexandre Abreu on 2016-03-07: Handle context menu in overlay webviews. Fixes: #1533727
Approved by: David Barth, Alberto Mardegan, Olivier Tilloy
1377. By CI Train Bot Account on 2016-03-07: Releasing 0.23+16.04.20160307-0ubuntu1
1378. By CI Train Bot Account on 2016-03-10: Resync trunk.
1379. By Launchpad Translations on behalf of phablet-team on 2016-03-10: Launchpad automatic translations update.
1380. By Olivier Tilloy on 2016-03-10: Add a touch selection controller. Fixes: #1376268, #1551494
Approved by: Alexandre Abreu
1381. By CI Train Bot Account on 2016-03-10: Releasing 0.23+16.04.20160310-0ubuntu1
1382. By Alberto Mardegan on 2016-03-11: Activate the Webapp only when we are ready to navigate to the webapp URL
Fixes: #1507995
Approved by: Alexandre Abreu
1383. By CI Train Bot Account on 2016-03-11: Releasing 0.23+16.04.20160311-0ubuntu1
1384. By CI Train Bot Account on 2016-03-17: Resync trunk.
1385. By Launchpad Translations on behalf of phablet-team on 2016-03-18: Launchpad automatic translations update.
1386. By Alexandre Abreu on 2016-03-18: Handle media access request from webcontainer main view and overlay views Fixes: #1554202
Approved by: Olivier Tilloy
1387. By CI Train Bot Account on 2016-03-18: Releasing 0.23+16.04.20160318-0ubuntu1
1388. By Olivier Tilloy on 2016-03-22: Tentative fix for a bug where the session state stored on disk is apparently corrupted, thus discarding the current browsing session. Fixes: #1531583
1389. By Olivier Tilloy on 2016-03-22: Make google maps work in complete mode on tablets. Fixes: #1560079
1390. By CI Train Bot Account on 2016-03-22: Releasing 0.23+16.04.20160322-0ubuntu1
1391. By Launchpad Translations on behalf of phablet-team on 2016-03-26: Launchpad automatic translations update.
1392. By Launchpad Translations on behalf of phablet-team on 2016-03-27: Launchpad automatic translations update.
1393. By Alexandre Abreu on 2016-04-05: Add --open-external-url-in-overlay option to allow externals urls (not part of patterns) are opened in overlays instead of external browser Fixes: #1548575
Approved by: David Barth, Alberto Mardegan
1394. By Alexandre Abreu on 2016-04-05: Handle live updates to theme color meta tag and reflect them in the top bar background color Fixes: #1550754
Approved by: Alberto Mardegan
1395. By Alexandre Abreu on 2016-04-05: Set address bar text color to a darker version of the theme color if one is defined in a webapp Fixes: #1548573
Approved by: Alberto Mardegan
1396. By CI Train Bot Account on 2016-04-05: Releasing 0.23+16.04.20160405-0ubuntu1
1397. By CI Train Bot Account on 2016-04-06: Resync trunk.
1398. By Launchpad Translations on behalf of phablet-team on 2016-04-07: Launchpad automatic translations update.
1399. By Olivier Tilloy on 2016-04-08: Remove workaround for bug #1526940 that was fixed in the latest release of the UITK.
1400. By Olivier Tilloy on 2016-04-08: Customize the contents of the media permission dialog to avoid truncated text. Fixes: #1554220
1401. By Olivier Tilloy on 2016-04-08: Fix broken webapp container autopilot tests. Fixes: #1557019
Approved by: Alexandre Abreu
1402. By Olivier Tilloy on 2016-04-08: Catch ESC key event one level up to ensure that it’s not incorrectly bubbled up to the outer component. Fixes: #1557016
1403. By Olivier Tilloy on 2016-04-08: Add dep8 tests and instructions to run them in qemu or on a phone.
Original work by Leo Arias and Vincent Ladeuil.
1404. By Olivier Tilloy on 2016-04-08: Rename debian packages to follow new QML module naming convention. Fixes: #1342031
Approved by: Timo Jyrinki
1405. By Olivier Tilloy on 2016-04-08: Make the autopilot tests more reliable when dragging the bottom edge. Fixes: #1560109
1406. By Olivier Tilloy on 2016-04-08: Fix issues with item selection in the downloads page:
- do not allow selecting multiple files when only one is expected
- do not allow entering delete mode (with a long press on an item) while in picker mode Fixes: #1534112, #1561575
1407. By Olivier Tilloy on 2016-04-08: Import QQuickShortcut from Qt 5.5 to properly handle window-level keyboard shortcuts.
We cannot bump the dependency on Qt to 5.5 as the stable overlay PPA for devices currently has Qt 5.4.1. Fixes: #1537782, #1542224, #1545802
1408. By Loïc Molinari on 2016-04-08: Made AddressBar height scalable with regards to the grid units system.
Approved by: Olivier Tilloy
1409. By Olivier Tilloy on 2016-04-08: Do not write the session to a temporary file when no target file is defined.
1410. By Olivier Tilloy on 2016-04-08: Fix a failing unit test with Qt 5.6. Fixes: #1565507
1411. By Olivier Tilloy on 2016-04-08: Fix unit tests when run under an sbuild chroot. Fixes: #1567294
1412. By Olivier Tilloy on 2016-04-08: Simplify the implementation of HistoryViewWide quite a bit,
and as a side effect fix a unit test failure when run against the staging branch of the UITK. Fixes: #1567337
1413. By CI Train Bot Account on 2016-04-08: Releasing 0.23+16.04.20160408.1-0ubuntu1
1414. By Olivier Tilloy on 2016-04-12: Update translation template.
1415. By Launchpad Translations on behalf of phablet-team on 2016-04-13: Launchpad automatic translations update.
1416. By Olivier Tilloy on 2016-04-13: Do not handle backspace as a window-level shortcut,
as it would take precedence over backspace events in HTML text fields. Fixes: #1569938
1417. By CI Train Bot Account on 2016-04-13: Releasing 0.23+16.04.20160413-0ubuntu1
1418. By CI Train Bot Account on 2016-04-14: Resync trunk.
1419. By Launchpad Translations on behalf of phablet-team on 2016-04-15: Launchpad automatic translations update.
1420. By Timo Jyrinki on 2016-04-15: Fix FTBFS on Qt 5.6 by adding a dependency on qttools5-dev-tools for qdoc Fixes: #1565502
Approved by: Olivier Tilloy
1421. By Olivier Tilloy on 2016-04-15: Add a progression symbol to list items that open new pages in settings. Fixes: #1517206
1422. By Olivier Tilloy on 2016-04-15: Add UA overrides for google hangouts to work on desktop, tablet and phone. Fixes: #1565055
1423. By Olivier Tilloy on 2016-04-15: Simplify focus handling in various places.
1424. By Olivier Tilloy on 2016-04-15: Remove duplicated list view focus rects,
and update the styling of the remaining ones to match that of the UITK. Fixes: #1570807
1425. By CI Train Bot Account on 2016-04-15: Releasing 0.23+16.04.20160415-0ubuntu1
1426. By CI Train Bot Account on 2016-04-19: Resync trunk.
1427. By Launchpad Translations on behalf of phablet-team on 2016-04-20: Launchpad automatic translations update.
1428. By Launchpad Translations on behalf of phablet-team on 2016-04-22: Launchpad automatic translations update.
1429. By Alexandre Abreu on 2016-04-25: Track SAML requests that are part of redirection chains and do not trigger a navigation requested delegate. Fixes: #1573017
Approved by: Alberto Mardegan
1430. By Alexandre Abreu on 2016-04-25: Fix invalid variable reference popupWindowController Fixes: #1572673
Approved by: Alberto Mardegan
1431. By CI Train Bot Account on 2016-04-25: Releasing 0.23+16.04.20160425.2-0ubuntu1
1432. By CI Train Bot Account on 2016-04-27: Resync trunk.
1433. By Olivier Tilloy on 2016-04-27: Autopkgtest fixes.
Approved by: Michał Sawicz
1434. By Olivier Tilloy on 2016-04-27: When sharing a link, correctly share its URL and title. Fixes: #1571361
1435. By CI Train Bot Account on 2016-04-27: Releasing 0.23+16.04.20160427-0ubuntu1
1436. By CI Train Bot Account on 2016-04-28: Resync trunk.
1437. By Olivier Tilloy on 2016-04-28: Use the UITK’s SwipeArea component for the bottom edge gesture recognition.
This requires oxide 1.14 to work well (because of bug #1459362). Fixes: #1458037, #1474533, #1491806
1438. By Olivier Tilloy on 2016-04-28: Skip geolocation autopilot tests because they are now failing with oxide 1.14.
1439. By Olivier Tilloy on 2016-04-28: Read the ubuntu version at build time, instead of hardcoding it. Fixes: #1466427
1440. By CI Train Bot Account on 2016-04-28: Releasing 0.23+16.04.20160428-0ubuntu1
1441. By CI Train Bot Account on 2016-04-29: Resync trunk.
1442. By Alexandre Abreu on 2016-04-29: Specify a parent for embedded uis being launched by webapps Fixes: #1550397
Approved by: Alberto Mardegan
1443. By Alexandre Abreu on 2016-04-29: Add facebook UA override that fixes photos not being displayed with the right size, and improves the UIs and features (add photos etc.) Fixes: #1457661, #1538056
Approved by: Alberto Mardegan
1444. By Alexandre Abreu on 2016-04-29: Tweak container context menu open in browser string Fixes: #1532937
Approved by: Olivier Tilloy
1445. By CI Train Bot Account on 2016-04-29: Releasing 0.23+16.04.20160429.1-0ubuntu1
1446. By CI Train Bot Account on 2016-05-02: Resync trunk.
1447. By Olivier Tilloy on 2016-05-02: Update translation template.
1448. By Launchpad Translations on behalf of phablet-team on 2016-05-03: Launchpad automatic translations update.
1449. By Launchpad Translations on behalf of phablet-team on 2016-05-04: Launchpad automatic translations update.
1450. By Alexandre Abreu on 2016-05-04: Introduce a new extension mechanism for the container that allows webapps to plugin into a discrete set of events coming from the container

Revision history for this message

system-apps-ci-bot (system-apps-ci-bot) wrote on 2016-07-13:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/581/rebuild

FAILED: Continuous integration, rev:1450
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/581/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/957
    UNSTABLE: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=default/172
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/957
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/861
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/861
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/861
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/858
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/858/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/858
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/858/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/858
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/858/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/858
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/858/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/858
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/858/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/858
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/858/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/858
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/858/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/858
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/858/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/858
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/858/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/581/rebuild

review: Needs Fixing (continuous-integration)

Reply

webbrowser-app

Merge lp://staging/~abreu-alexandre/webbrowser-app/container-extension into lp://staging/webbrowser-app

Commit message

Description of the change

Unmerged revisions

Preview Diff

Subscribers