The Webapps-core project

Merge lp://staging/~abreu-alexandre/webapps-core/fix-gmaps-url-pattern into lp://staging/~osomon/webapps-core/gmaps-intent-hook

  1. fix-gmaps-url-pattern
  2. Merge into gmaps-intent-hook
Proposed by Alexandre Abreu
Status: Merged
Merged at revision: 107
Proposed branch: lp://staging/~abreu-alexandre/webapps-core/fix-gmaps-url-pattern
Merge into: lp://staging/~osomon/webapps-core/gmaps-intent-hook
Diff against target: 12 lines (+1/-1)
1 file modified
webapp-googlemaps/webapp-googlemaps.desktop (+1/-1)
To merge this branch: bzr merge lp://staging/~abreu-alexandre/webapps-core/fix-gmaps-url-pattern
Reviewer Review Type Date Requested Status
Olivier Tilloy Pending
Review via email: mp+247441@code.staging.launchpad.net

Commit message

Fix webapp url pattern

Description of the change

Fix webapp url pattern

To post a comment you must log in.
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

Rationale:

In 'https?://maps.google.*' the last wildcard does strictly correspond to the TLD of the URL. So e. g. in the case of intents redirecting to a specific location as in

https://bugs.launchpad.net/webbrowser-app/+bug/1407709

no pattern matches when a path + query string is appended to the URL,

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches