The Webapps-core project

Merge lp://staging/~abreu-alexandre/webapps-core/email-clear-cache-once-on-update into lp://staging/webapps-core

  1. email-clear-cache-once-on-update
  2. Merge into trunk
Proposed by Alexandre Abreu
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 124
Merged at revision: 125
Proposed branch: lp://staging/~abreu-alexandre/webapps-core/email-clear-cache-once-on-update
Merge into: lp://staging/webapps-core
Diff against target: 28 lines (+4/-2)
2 files modified
webapp-gmail/manifest.json (+3/-2)
webapp-gmail/webapp-click.hook (+1/-0)
To merge this branch: bzr merge lp://staging/~abreu-alexandre/webapps-core/email-clear-cache-once-on-update
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
Review via email: mp+279513@code.staging.launchpad.net

Commit message

Force cache deletion on update to mitigate for potential issues created by its content & saml requests for some accounts

Description of the change

Force cache deletion on update to mitigate for potential issues created by its content & saml requests for some accounts.

This change relies on:

https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1522562

To post a comment you must log in.
Revision history for this message
Alberto Mardegan (mardy) wrote :

LGTM, but is this really happening on update? Shouldn't we have an "update" key in the manifest (I guess we can add it already, even if your other MP is not merged yet)?

review: Needs Information
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> LGTM, but is this really happening on update? Shouldn't we have an "update"
> key in the manifest (I guess we can add it already, even if your other MP is
> not merged yet)?

I considered that it was mostly to fix a "one off" issue (the gmail cache one).
Eventhough we will update the click package, from the point of view of the webapp
click hook it will be considered an install since no click hook file is already
found in ~/.local/share/webapp-container.

Revision history for this message
Alberto Mardegan (mardy) wrote :

Ah, then it's OK!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: