Merge lp://staging/~abreu-alexandre/unity-webapps-qml/handle-bidirectional-callback-params into lp://staging/unity-webapps-qml
Proposed by
Alexandre Abreu
| Status: | Merged |
|---|---|
| Approved by: | Robert Bruce Park |
| Approved revision: | 129 |
| Merged at revision: | 127 |
| Proposed branch: | lp://staging/~abreu-alexandre/unity-webapps-qml/handle-bidirectional-callback-params |
| Merge into: | lp://staging/unity-webapps-qml |
| Diff against target: |
939 lines (+473/-56) 19 files modified
debian/rules (+1/-1) debian/unity-webapps-qml-autopilot.install (+3/-3) src/Ubuntu/UnityWebApps/Settings.qml (+1/-1) src/Ubuntu/UnityWebApps/UnityWebApps.js (+38/-4) src/Ubuntu/UnityWebApps/UnityWebApps.pro (+0/-3) src/Ubuntu/UnityWebApps/UnityWebApps.qml (+50/-21) src/Ubuntu/UnityWebApps/UnityWebAppsUtils.js (+68/-0) src/Ubuntu/UnityWebApps/common/js/unity-binding-bridge.js (+63/-0) tests/autopilot/autopilot.pro (+19/-1) tests/autopilot/html/test_webapps_callback_dispatch.html (+57/-0) tests/autopilot/html/test_webapps_callback_dispatch_api.js.in (+58/-0) tests/autopilot/qml/FullWebViewApp.qml (+20/-1) tests/autopilot/qml/test_webapps_callback_dispatch_api.qml (+14/-0) tests/autopilot/unity_webapps_qml/tests/__init__.py (+9/-5) tests/autopilot/unity_webapps_qml/tests/test_callbackDispatch.py (+60/-0) tests/integration/integration.pro (+0/-3) tests/tests.pro (+1/-1) tests/unit/test_qml/tst_dispatch.qml (+4/-4) tools/qml-launcher/qml-launcher.cpp (+7/-8) |
| To merge this branch: | bzr merge lp://staging/~abreu-alexandre/unity-webapps-qml/handle-bidirectional-callback-params |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
| WebApps | Pending | ||
|
Review via email:
|
|||
Commit message
Add bidirectional callback support between js <-> qml,
Description of the change
Add bidirectional callback support between js <-> qml,
The current situation is that javascript can (and has to) handoff js callbacks to qml, so that events are properly propagated and translated. One use case recently came up that highlighted the limitation that basically the "callback translation between js & qml" does not work both ways. The use case is for content hub share handler that might ask js to call a qml callback when an operation is done.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Alberto Mardegan (mardy) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:135
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://