unity-webapps-qml

Merge lp://staging/~abreu-alexandre/unity-webapps-qml/cleanup-logs into lp://staging/unity-webapps-qml

  1. cleanup-logs
  2. Merge into trunk
Proposed by Alexandre Abreu
Status: Merged
Approved by: Alexandre Abreu
Approved revision: 155
Merged at revision: 155
Proposed branch: lp://staging/~abreu-alexandre/unity-webapps-qml/cleanup-logs
Merge into: lp://staging/unity-webapps-qml
Diff against target: 142 lines (+0/-27)
5 files modified
src/Ubuntu/UnityWebApps/UnityWebApps.qml (+0/-2)
src/Ubuntu/UnityWebApps/UnityWebAppsUtils.js (+0/-1)
src/Ubuntu/UnityWebApps/common/js/unity-binding-bridge.js (+0/-7)
src/Ubuntu/UnityWebApps/plugin/unity-webapps-api.cpp (+0/-9)
src/Ubuntu/UnityWebApps/plugin/unity-webapps-app-model.cpp (+0/-8)
To merge this branch: bzr merge lp://staging/~abreu-alexandre/unity-webapps-qml/cleanup-logs
Reviewer Review Type Date Requested Status
David Barth (community) Approve
Justin McPherson Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+264444@code.staging.launchpad.net

Commit message

Clean up very verbose and non informative logs

Description of the change

Clean up very verbose and non informative logs

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:155
http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-ci/179/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-wily-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-qml-wily-armhf-ci/1

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-webapps-qml-ci/179/rebuild

review: Approve (continuous-integration)
Revision history for this message
Justin McPherson (justinmcp) :
review: Approve
Revision history for this message
David Barth (dbarth) wrote :

It does clean the logs. I would keep some of the messages as comments in the code though, as some of the cases are not totally obvious when reading the source.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: