Ubuntu UI Toolkit

Merge lp://staging/~abreu-alexandre/ubuntu-ui-toolkit/fix-urihandler-register-service into lp://staging/ubuntu-ui-toolkit/staging

  1. fix-urihandler-register-service
  2. Merge into staging
Proposed by Alexandre Abreu
Status: Merged
Approved by: Zsombor Egri
Approved revision: 1110
Merged at revision: 1381
Proposed branch: lp://staging/~abreu-alexandre/ubuntu-ui-toolkit/fix-urihandler-register-service
Merge into: lp://staging/ubuntu-ui-toolkit/staging
Diff against target: 11 lines (+0/-1)
1 file modified
modules/Ubuntu/Components/plugin/ucurihandler.cpp (+0/-1)
To merge this branch: bzr merge lp://staging/~abreu-alexandre/ubuntu-ui-toolkit/fix-urihandler-register-service
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+240424@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-10-08.

Description of the change

Remove the unecessary DBUS bindingi to global address org.freedesktop.Application by the UriHAndler. It actually fails for confined apps and the uri-dispatcher anyway does not work by directly calling into the exposed "well known names" exposed on the bus as TEd explains here:

https://bugs.launchpad.net/ubuntu/+source/apparmor-easyprof-ubuntu/+bug/1342129

but by directly calling into the process dbus connection.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:1110
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/2166/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5755
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4014
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-utopic-amd64-ci/112
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-utopic-armhf-ci/112
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-utopic-armhf-ci/112/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5420
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7007
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7007/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14427
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3383
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4341
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4341/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-toolkit-ci/2166/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote : Posted in a previous version of this proposal

Alex, is this bug listed in the sheet with the bugs to be landed in RTM? If not, the fix must be submitted agains staging.

review: Needs Information
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

@Zombor: right, resubmitted against staging

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1110
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1191/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6403
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/1024
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/1023
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/1023/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/1023
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/6006
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7655
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7655/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15344

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1191/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote :

Looks ok to me...

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches