Ubuntu HTML5 UI SDK

Merge lp://staging/~abreu-alexandre/ubuntu-html5-theme/control-automatic-orientation-of-app into lp://staging/ubuntu-html5-theme

  1. control-automatic-orientation-of-app
  2. Merge into trunk
Proposed by Alexandre Abreu
Status: Work in progress
Proposed branch: lp://staging/~abreu-alexandre/ubuntu-html5-theme/control-automatic-orientation-of-app
Merge into: lp://staging/ubuntu-html5-theme
Diff against target: 78 lines (+23/-1)
2 files modified
src/plugin/Ubuntu/WebApps/WebAppContainer.qml (+8/-1)
src/ubuntu-html5-app-launcher/main.cpp (+15/-0)
To merge this branch: bzr merge lp://staging/~abreu-alexandre/ubuntu-html5-theme/control-automatic-orientation-of-app
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu HTML5 Theme Developers Pending
Review via email: mp+208053@code.staging.launchpad.net

Commit message

Allow control of automatic orientation of the app

Description of the change

Allow control of automatic orientation of the app.

To test it in the device:

bzr branch lp:~abreu-alexandre/ubuntu-html5-theme/control-automatic-orientation-of-app
cd control-automatic-orientation-of-app
cmake .
make
cd src/ubuntu-html5-app-launcher
QML2_IMPORT_PATH=`pwd`/../src ./ubuntu-html5-app-launcher --www=../../examples/html5-theme/apps/rss-reader/ --desktop_file_hint=/usr/share/applications/webbrowser-app.desktop

-> you should be able when rotating the device to see the app screen rotate too

QML2_IMPORT_PATH=`pwd`/../src ./ubuntu-html5-app-launcher --disableAutomaticOrientation --www=../../examples/html5-theme/apps/rss-reader/ --desktop_file_hint=/usr/share/applications/webbrowser-app.desktop

-> you should NOT be able when rotating the device to see the app screen rotate too

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:147
http://jenkins.qa.ubuntu.com/job/ubuntu-html5-theme-ci/113/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3477
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-html5-theme-trusty-amd64-ci/97
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-html5-theme-trusty-armhf-ci/97
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3057
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3480
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3480/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-html5-theme-ci/113/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
David Barth (dbarth) wrote :

Feels like a race condition solved by a different initialization path.

I'm not sure the command line option really makes sense but for tests though: can you remove it? less code is better.

Reply
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> Feels like a race condition solved by a different initialization path.
>
> I'm not sure the command line option really makes sense but for tests though:
> can you remove it? less code is better.

Not sure I understand the comment, ... this is a new command line arg & option
... that's it,

Reply
Revision history for this message
David Barth (dbarth) wrote :

Le 25/02/2014 14:35, Alexandre Abreu a écrit :
>> Feels like a race condition solved by a different initialization path.
>>
>> I'm not sure the command line option really makes sense but for tests though:
>> can you remove it? less code is better.
> Not sure I understand the comment, ... this is a new command line arg & option
> ... that's it,
 right, but less is better: more options means more code and backward
compatibility overhead in the future.

David

Reply
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> Le 25/02/2014 14:35, Alexandre Abreu a écrit :
> >> Feels like a race condition solved by a different initialization path.
> >>
> >> I'm not sure the command line option really makes sense but for tests
> though:
> >> can you remove it? less code is better.
> > Not sure I understand the comment, ... this is a new command line arg &
> option
> > ... that's it,

> right, but less is better: more options means more code and backward
> compatibility overhead in the future.

atm there is no way for dev, to specify that their apps runs & supports
automatic rotation or not ... which is something lacking. This is not
just for the sake of adding a setting, but something provided by
other platforms that we dont support & I saw a need for while working on
html5 apps

Reply
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

I did set up as WIP since I want to add something else

Reply

Unmerged revisions

147. By Alexandre Abreu

Allow control of automatic orientation of the app

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches