Ubuntu HTML5 UI SDK

Merge lp://staging/~abreu-alexandre/ubuntu-html5-theme/add-button-class-ubuntu into lp://staging/~ubuntu-html5-theme-devs/ubuntu-html5-theme/ambiance

  1. add-button-class-ubuntu
  2. Merge into ambiance
Proposed by Alexandre Abreu
Status: Merged
Approved by: Alexandre Abreu
Approved revision: 96
Merged at revision: 95
Proposed branch: lp://staging/~abreu-alexandre/ubuntu-html5-theme/add-button-class-ubuntu
Merge into: lp://staging/~ubuntu-html5-theme-devs/ubuntu-html5-theme/ambiance
Diff against target: 61 lines (+13/-3)
3 files modified
0.1/ambiance/css/buttons.css (+6/-0)
0.1/ambiance/js/buttons.js (+1/-1)
0.1/examples/widgets/Buttons.html (+6/-2)
To merge this branch: bzr merge lp://staging/~abreu-alexandre/ubuntu-html5-theme/add-button-class-ubuntu
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Adnane Belmadiaf Approve
Review via email: mp+195869@code.staging.launchpad.net

Commit message

Add button class 'ubuntu'

Description of the change

Add button class 'ubuntu'

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:95
http://jenkins.qa.ubuntu.com/job/ubuntu-html5-theme-ci/23/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/887
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-html5-theme-trusty-amd64-ci/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-html5-theme-trusty-armhf-ci/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/798
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/887
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/887/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-html5-theme-ci/23/rebuild

review: Approve (continuous-integration)
Revision history for this message
Adnane Belmadiaf (daker) wrote :

The JS docs needs to be updated too https://bazaar.launchpad.net/~ubuntu-html5-theme-devs/ubuntu-html5-theme/ambiance/view/head:/0.1/ambiance/js/buttons.js#L26

review: Needs Fixing
lp://staging/~abreu-alexandre/ubuntu-html5-theme/add-button-class-ubuntu updated
96. By Alexandre Abreu

update doc

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> The JS docs needs to be updated too https://bazaar.launchpad.net/~ubuntu-html5
> -theme-devs/ubuntu-
> html5-theme/ambiance/view/head:/0.1/ambiance/js/buttons.js#L26
done

Revision history for this message
Adnane Belmadiaf (daker) wrote :

+1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:96
http://jenkins.qa.ubuntu.com/job/ubuntu-html5-theme-ci/26/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1203
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-html5-theme-trusty-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-html5-theme-trusty-armhf-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1068
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1203
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1203/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-html5-theme-ci/26/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches