Merge lp://staging/~abreu-alexandre/qtcreator-plugin-ubuntu/add-html5-tests-to-template into lp://staging/qtcreator-plugin-ubuntu

PASSED: Continuous integration, rev:368
http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-ci/527/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-amd64-ci/61
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-armhf-ci/61

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtcreator-plugin-ubuntu-ci/527/rebuild

This looks really good.

It would be awesome if we could integrate this with the make files, so we could run the tests locally with make test and make autopilot.

Also there are some changes needed to get this running with adt-run in a phone. You can copy most of the things from my branch to make them compatible with local and testbed executions: https://code.launchpad.net/~canonical-platform-qa/webapps-core/x-test/+merge/249580

Both things would be ok to do in future branches, to get this one landed quicker.

Some things to fix in the comments...

This is much improved on the default, thanks! I added some additional comments for cleanup.

PASSED: Continuous integration, rev:369
http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-ci/528/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-amd64-ci/62
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-armhf-ci/62

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtcreator-plugin-ubuntu-ci/528/rebuild

> Also there are some changes needed to get this running with adt-run in a
> phone. You can copy most of the things from my branch to make them compatible
> with local and testbed executions: https://code.launchpad.net/~canonical-
> platform-qa/webapps-core/x-test/+merge/249580

This is for html5 apps, do we need to make them "adt-run enabled" ?

Comments have been addressed

Updated

PASSED: Continuous integration, rev:370
http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-ci/530/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-amd64-ci/64
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-armhf-ci/64

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtcreator-plugin-ubuntu-ci/530/rebuild

> > Also there are some changes needed to get this running with adt-run in a
> > phone. You can copy most of the things from my branch to make them
> compatible
> > with local and testbed executions: https://code.launchpad.net/~canonical-
> > platform-qa/webapps-core/x-test/+merge/249580
>
> This is for html5 apps, do we need to make them "adt-run enabled" ?
>
> Comments have been addressed

Yes, that would be lovely. But not necessarily on the same branch.

Trying to run this as-is fails at first pass:

Unit
http://paste.ubuntu.com/10834284/

Autopilot
http://paste.ubuntu.com/10834211/

Going to play and see what I might be missing.

Ok, seems you definitely need nodejs from upstream as the archive version is too old :-( I had success using nodejs 0.12.

I did get one warning.
npm WARN package.json my-app@0.1.0 No repository field.

So everything works for me on the unit test side; using nodejs from the archive. That's good to go.

On the autopilot side, the tests don't work as the port number isn't correct; the hardcoded port number is not the one the webview launches with.

> So everything works for me on the unit test side; using nodejs from the
> archive. That's good to go.
>
> On the autopilot side, the tests don't work as the port number isn't correct;
> the hardcoded port number is not the one the webview launches with.

I updated the AP code, there was an issue w/ env vars for the local IP devtools server not being set,

> So everything works for me on the unit test side; using nodejs from the
> archive. That's good to go.
>
> On the autopilot side, the tests don't work as the port number isn't correct;
> the hardcoded port number is not the one the webview launches with.

I updated the AP code, there was an issue w/ env vars for the local IP devtools server not being set,

PASSED: Continuous integration, rev:371
http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-ci/533/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-amd64-ci/67
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-armhf-ci/67

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtcreator-plugin-ubuntu-ci/533/rebuild

Everything works, +1 from me.

If it works, I'm happy too. Lets get a review from zoltan or benjamin to get this landed.

Does it work on LTS/Utopic/Vivid?

Who maintains that python3-selenium package?

> Does it work on LTS/Utopic/Vivid?

yes,

> Who maintains that python3-selenium package?

this is an upstream element packaged for our needs (removing some java deps),

> > Does it work on LTS/Utopic/Vivid?
>
> yes,

In the PPA I see only Trusty and Vivid packages not Utopic. Many of the SDk users are not migrated from Utopic and we support Utopic for about a month after the Vivid release.

>
> > Who maintains that python3-selenium package?
>
> this is an upstream element packaged for our needs (removing some java deps),

I think the best would be to include this package to the SDK and publish it to 15.10 archive and to the SDK PPA.

I would suggest to change the vesrion umber of the package to show the target release. Like 2.4.4-0ubuntu1~0trusty1

I see that this big MR effects only the HTML5 template namespace + the license of the package with correct content. So it is good to go, but the python3-selenium should be productized and released in a proper way.