Code review comment for lp://staging/~abreu-alexandre/oxide/file-picker-done-guard

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> > > Haven't I already reviewed this change with a request to add a test for
> it?
> >
> > Did you already? ... I couldn't find another branch for that,
> >
> > I'll add a test,
>
> It was your branch :)
>
> The review URL was https://code.launchpad.net/~abreu-alexandre/oxide
> /filepicker-accept-nullcheck/+merge/264833, but it seems to have disappeared
> now. I approved it around July last year with a comment that it should be
> committed with a test.

Right ! ... I re-stumbled on that issue this week, not sure why the branch is not there anymore,

« Back to merge proposal