Oxide

Merge lp://staging/~abreu-alexandre/oxide/file-picker-done-guard into lp://staging/~oxide-developers/oxide/oxide.trunk

  1. file-picker-done-guard
  2. Merge into oxide.trunk
Proposed by Alexandre Abreu
Status: Work in progress
Proposed branch: lp://staging/~abreu-alexandre/oxide/file-picker-done-guard
Merge into: lp://staging/~oxide-developers/oxide/oxide.trunk
Diff against target: 13 lines (+3/-0)
1 file modified
shared/browser/oxide_file_picker.cc (+3/-0)
To merge this branch: bzr merge lp://staging/~abreu-alexandre/oxide/file-picker-done-guard
Reviewer Review Type Date Requested Status
Chris Coulson Needs Fixing
Review via email: mp+286374@code.staging.launchpad.net

Commit message

Add guard for file picker done

Description of the change

Add guard for file picker done

To post a comment you must log in.
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Haven't I already reviewed this change with a request to add a test for it?

Reply
Revision history for this message
Chris Coulson (chrisccoulson) :
review: Needs Fixing
Reply
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> Haven't I already reviewed this change with a request to add a test for it?

Did you already? ... I couldn't find another branch for that,

I'll add a test,

Reply
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

> > Haven't I already reviewed this change with a request to add a test for it?
>
> Did you already? ... I couldn't find another branch for that,
>
> I'll add a test,

It was your branch :)

The review URL was https://code.launchpad.net/~abreu-alexandre/oxide/filepicker-accept-nullcheck/+merge/264833, but it seems to have disappeared now. I approved it around July last year with a comment that it should be committed with a test.

Reply
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> > > Haven't I already reviewed this change with a request to add a test for
> it?
> >
> > Did you already? ... I couldn't find another branch for that,
> >
> > I'll add a test,
>
> It was your branch :)
>
> The review URL was https://code.launchpad.net/~abreu-alexandre/oxide
> /filepicker-accept-nullcheck/+merge/264833, but it seems to have disappeared
> now. I approved it around July last year with a comment that it should be
> committed with a test.

Right ! ... I re-stumbled on that issue this week, not sure why the branch is not there anymore,

Reply

Unmerged revisions

1351. By Alexandre Abreu

Add guard for file picker done()

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches