Merge lp://staging/~abreu-alexandre/cordova-ubuntu/fix-icu-dev-version into lp://staging/cordova-ubuntu/2.8
Proposed by
Robert Bruce Park
| Status: | Rejected | ||||
|---|---|---|---|---|---|
| Rejected by: | Robert Bruce Park | ||||
| Proposed branch: | lp://staging/~abreu-alexandre/cordova-ubuntu/fix-icu-dev-version | ||||
| Merge into: | lp://staging/cordova-ubuntu/2.8 | ||||
| Diff against target: |
78 lines (+6/-25) 2 files modified
debian/control (+0/-1) src/plugins/globalization.cpp (+6/-24) |
||||
| To merge this branch: | bzr merge lp://staging/~abreu-alexandre/cordova-ubuntu/fix-icu-dev-version | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Robert Bruce Park (community) | Disapprove | ||
|
Review via email:
|
|||
Commit message
Rip out ICU, which was conflicting with an incompatible version of ICU pulled in by Qt itself.
To post a comment you must log in.
Unmerged revisions
- 253. By Alexandre Abreu
-
remove icu references for now
- 252. By Alexandre Abreu
-
Fix icu dev version pulled
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
dholbach and I both tested that this allows the tests to run.