Merge lp://staging/~abentley/lp-release-manager-tools/exclude-exact-finish into lp://staging/~sinzui/lp-release-manager-tools/trunk
Proposed by
Aaron Bentley
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~abentley/lp-release-manager-tools/exclude-exact-finish |
| Merge into: | lp://staging/~sinzui/lp-release-manager-tools/trunk |
| Diff against target: |
19 lines (+2/-2) 1 file modified
lp_release_tools/report_bugs.py (+2/-2) |
| To merge this branch: | bzr merge lp://staging/~abentley/lp-release-manager-tools/exclude-exact-finish |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Curtis Hovey | code | Approve | |
|
Review via email:
|
|||
Commit message
Ignore bugs created or closed at the cycle's finish.
Description of the change
Bug events (being open or closed) should not be part of two cycles. The current collation includes the start and finish of the cycle. The finish of one cycle is the start of the following cycle (if there is one). So an event that happens at the finish of a cycle will usually be part of that cycle and the following cycle.
To fix this, we must exclude either the start or the finish of the cycle. To me, it is intuitive that the start of the cycle should be included, therefore we should exclude the end of the cycle. This branch does that.
To post a comment you must log in.
Unmerged revisions
- 31. By Aaron Bentley
-
Exclude dates at the 'finish' value.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
\o/ I have been meaning to do this.