Launchpad itself

Merge lp://staging/~abentley/launchpad/fix-recipebuilder into lp://staging/launchpad

fix-recipebuilder
Merge into devel

Proposed by Aaron Bentley on 2010-05-18

Status:

Merged

Merged at revision:

10917

Proposed branch:

lp://staging/~abentley/launchpad/fix-recipebuilder

Merge into:

lp://staging/launchpad

Diff against target:

139 lines (+40/-7)

5 files modified

lib/lp/code/interfaces/sourcepackagerecipebuild.py (+3/-1)
lib/lp/code/model/recipebuilder.py (+1/-1)
lib/lp/code/model/sourcepackagerecipebuild.py (+9/-3)
lib/lp/code/model/tests/test_recipebuilder.py (+23/-0)
lib/lp/testing/factory.py (+4/-2)

To merge this branch:

bzr merge lp://staging/~abentley/launchpad/fix-recipebuilder

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Paul Hummer (community)	code	2010-05-18	Approve on 2010-05-18
Review via email: mp+25528@code.staging.launchpad.net

Commit message

Fix verifyBuildRequest to use valid attribute

Description of the change

= Summary =
Fix bug #581899: verifyBuildRequest is broken

== Proposed fix ==
Update to use SourcePackageRecipeBuild.is_virtualized, like binary builds do.

== Pre-implementation notes ==
Discussed with noodles and bigjools

== Implementation details ==
Make SourcePackageRecipeBuildJob.virtualized mirror
SourcePackageRecipeBuild.is_virtualized

Allow overriding the pocket of a Build.

Add tests for error paths in verifyBuildRequest

== Tests ==
bin/test -t verifyBuildRequest test_recipebuilder

== Demo and Q/A ==
I am unclear how to test this.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/code/interfaces/sourcepackagerecipebuild.py
  lib/lp/testing/factory.py
  lib/lp/code/model/sourcepackagerecipebuild.py
  lib/lp/code/model/tests/test_recipebuilder.py
  lib/lp/code/model/recipebuilder.py