Merge lp://staging/~abentley/launchpad/fix-branch-precondition into lp://staging/launchpad
| Status: | Merged |
|---|---|
| Merged at revision: | 12838 |
| Proposed branch: | lp://staging/~abentley/launchpad/fix-branch-precondition |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
35 lines (+15/-2) 1 file modified
lib/lp/translations/javascript/sourcepackage_sharing_details.js (+15/-2) |
| To merge this branch: | bzr merge lp://staging/~abentley/launchpad/fix-branch-precondition |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gavin Panella (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Fix 412 Precodition failed setting branch.
Description of the change
= Summary =
Fix bug #758919: Precondition failed error using the selecting upstream source branch in translations sharing page.
== Proposed fix ==
Reload the productseries after submitting usage form.
== Pre-implementation notes ==
None
== Implementation details ==
The error occurred if the translation usage was changed before the branch was changed. It's not clear why changing the product changes the ETAG of the productseries, but it apparently does. Reloading the productseries refrehes the ETAG, which allows the branch to be set. This solution adds latency, but is simple and correct.
== Tests ==
None
== Demo and Q/A ==
Go to https:/
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
| Gavin Panella (allenap) | # |
