Launchpad itself

Merge lp://staging/~abentley/launchpad/delete-builds into lp://staging/launchpad/db-devel

delete-builds
Merge into db-devel

Proposed by Aaron Bentley on 2010-10-22

Status:

Merged

Approved by:

Robert Collins on 2010-10-22

Approved revision:

no longer in the source branch.

Merged at revision:

9922

Proposed branch:

lp://staging/~abentley/launchpad/delete-builds

Merge into:

lp://staging/launchpad/db-devel

Diff against target:

119 lines (+43/-0)

5 files modified

database/schema/security.cfg (+2/-0)
lib/lp/buildmaster/model/packagebuild.py (+6/-0)
lib/lp/buildmaster/tests/test_packagebuild.py (+14/-0)
lib/lp/code/model/sourcepackagerecipebuild.py (+2/-0)
lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+19/-0)

To merge this branch:

bzr merge lp://staging/~abentley/launchpad/delete-builds

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Robert Collins (community)		2010-10-22	Approve on 2010-10-22
Review via email: mp+39184@code.staging.launchpad.net

Commit message

SourcePackageRecipeBuild.destroySelf clean up referenced objects.

Description of the change

= Summary =
Fix bug# 665301: SourcePackageRecipe.destroySelf does not clean up builds
properly.

== Proposed fix ==
Implement PackageBuild.destroySelf, and have
SourcePackageRecipeBuild.destroySelf call it.

== Pre-implementation notes ==
None

== Implementation details ==
Can't think of anything

== Tests ==
bin/test -t test_destroySelf_destroys_referenced -t
test_destroySelf_removes_BuildFarmJob

== Demo and Q/A ==
None

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/code/model/tests/test_sourcepackagerecipebuild.py
  lib/lp/buildmaster/tests/test_packagebuild.py
  database/schema/security.cfg
  lib/lp/buildmaster/model/packagebuild.py
  lib/lp/code/model/sourcepackagerecipebuild.py

./database/schema/security.cfg
     702: Line exceeds 78 characters.
     703: Line exceeds 78 characters.
     704: Line exceeds 78 characters.
     730: Line exceeds 78 characters.
     734: Line exceeds 78 characters.
     789: Line exceeds 78 characters.
     802: Line exceeds 78 characters.
     803: Line exceeds 78 characters.
     820: Line exceeds 78 characters.
     821: Line exceeds 78 characters.
     822: Line exceeds 78 characters.
     823: Line exceeds 78 characters.
     824: Line exceeds 78 characters.
     876: Line exceeds 78 characters.
     877: Line exceeds 78 characters.
     878: Line exceeds 78 characters.
     908: Line exceeds 78 characters.

Revision history for this message

Robert Collins (lifeless) wrote on 2010-10-22:

It seems unidiomatic to have a destroySelf that just does 'remove' on another table; might want to consider delegating to the other objects destroySelf too.

review: Approve