Merge lp://staging/~abentley/launchpad/daily-builds-api into lp://staging/launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jelmer Vernooij | ||||
Approved revision: | no longer in the source branch. | ||||
Merge reported by: | Aaron Bentley | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp://staging/~abentley/launchpad/daily-builds-api | ||||
Merge into: | lp://staging/launchpad | ||||
Prerequisite: | lp://staging/~abentley/launchpad/daily-builds-ui | ||||
Diff against target: |
118 lines (+22/-8) 5 files modified
lib/canonical/launchpad/interfaces/_schema_circular_imports.py (+2/-0) lib/lp/code/interfaces/sourcepackagerecipe.py (+4/-4) lib/lp/code/model/tests/test_sourcepackagerecipe.py (+6/-1) lib/lp/registry/interfaces/person.py (+7/-1) lib/lp/registry/model/person.py (+3/-2) |
||||
To merge this branch: | bzr merge lp://staging/~abentley/launchpad/daily-builds-api | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jelmer Vernooij (community) | code | Approve | |
Review via email: mp+26335@code.staging.launchpad.net |
Commit message
Implement API for daily builds.
Description of the change
= Summary =
Fix bug #586954: Launchpad should provide daily builds over API
== Proposed fix ==
Expose build_daily and daily_build_archive when creating recipes and as member
variables.
== Pre-implementation notes ==
None
== Implementation details ==
None
== Tests ==
bin/test -v test_sourcepack
== Demo and Q/A ==
Write a script using the LP API. Have it create a recipe, specifying
build_daily and daily_build_
Access the build_daily and daily_build_archive member variables.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files:
cronscripts/
lib/lp/
lib/lp/
lib/lp/
lib/canonical
lib/lp/
lib/lp/
database/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
configs/
lib/lp/
lib/lp/
lib/lp/
lib/canonical
== Pyflakes Doctest notices ==
lib/lp/
689: local variable 'pub_binaries' is assigned to but never used
== Pyflakes notices ==
cronscripts/
19: 'canonical' imported but unused
== Pylint notices ==
cronscripts/
19: [W0611] Unused import canonical
lib/lp/
207: [W0702, SourcePackageRe
lib/lp/
850: [C0322, IPersonPublic.
distroserie
^
name=
recipe_
sourcepacka
daily_
build_
)
@export_
def createRecipe(name, description, recipe_text, distroseries,
sourcepacka
build_
1414: [C0322, IPersonEditRest
status=
^
comment=
@export_
def addMember(person, reviewer, status=
comment=None, force_team_
may_
1455: [C0322, IPersonEditRest
comment=Text())
^
@export_
def acceptInvitatio
1467: [C0322, IPersonEditRest
comment=Text())
^
@export_
def declineInvitati
1764: [C0322, IPersonSet.newTeam] Operator not preceded by a space
defaultmemb
^
defaultrene
@operation_
subscriptio
title=
required=False, default=
@export_
ITeam, ['name', 'displayname', 'teamdescription',
'defaultmem
def newTeam(teamowner, name, displayname, teamdescription
subscriptio
defaultmemb
1833: [C0322, IPersonSet.
created_
^
title=
created_
title=
)
@operation_
@export_
def findPerson(text="", exclude_
must_
created_
lib/lp/
150: [C0322, ISourcePackageR
distroserie
^
)
@export_
def requestBuild(
lib/lp/
1265: [W0104, Person.addMember] Statement seems to have no effect
+ :param daily_build_ archive: The archive to user for daily builds.
^^ You probably mean s/user/use/ here?
The newline on line 81 of your diff seems unnecessary.