juju-release-tools

Merge lp://staging/~abentley/juju-release-tools/sync-command-2 into lp://staging/juju-release-tools

  1. sync-command-2
  2. Merge into trunk
Proposed by Aaron Bentley
Status: Merged
Merged at revision: 226
Proposed branch: lp://staging/~abentley/juju-release-tools/sync-command-2
Merge into: lp://staging/juju-release-tools
Diff against target: 358 lines (+196/-53)
2 files modified
azure_publish_tools.py (+46/-22)
tests/test_azure_publish_tools.py (+150/-31)
To merge this branch: bzr merge lp://staging/~abentley/juju-release-tools/sync-command-2
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+274634@code.staging.launchpad.net

Commit message

Add azure_publish_tools sync command.

Description of the change

This branch adds a "sync" command to azure_publish_tools.py.

This allows us to publish arbitrary streams to Azure.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you. I have a few questions and comments, but nothing that blocks.

review: Approve (code)
Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2015-10-15 05:03 PM, Curtis Hovey wrote:
>> COMMANDS = (LIST, PUBLISH, DELETE)
>
> Is COMMANDS still needed? I think it is unneeded since this script
> was converted to argumentparser.

It is down to one call site in get_option_parser now, so I'll expand
it there.

> We exorcised "purpose" from this function. Maybe the docstring
> should be: Publish the local file to the remote location,
>
>>
>> The file is broken down into blocks that can be uploaded within

Works for me.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWIBn8AAoJEK84cMOcf+9hEIUIAJZwvLpERnUm7pyHzf62FGOA
HDeHz8GSgrl4T5n4yi9ZeBlpPMSu9rNa6xESKj9CcCx1eUD6SISZ54OXC6oVPMNh
Xaf4G++ZoxcmQ46QUQdmmvEhZP51BPOc5l74DCohaqYeJr+fqKcxYbjTIK28ueFZ
bW0jCT8z8LbKTTAlVx5Rz1vdUahj8YFaK2RTsh7DrC0D0EA6JPXk51TROZEAF8QC
1ZG79UvfQMnl8ComY7ylKIHcjh7YGOqDMXaJU45ynNNDSegLVR3cqr8VnJJD3uHQ
a4974t1GT4yllXqh3Ljpdss5ksd1+snb1tHLdE/U/5gx4O54o9Z9t3yiItFcOmg=
=kqjG
-----END PGP SIGNATURE-----

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches