Merge lp://staging/~abentley/juju-release-tools/no-sha1 into lp://staging/juju-release-tools

Proposed by Aaron Bentley
Status: Merged
Merged at revision: 237
Proposed branch: lp://staging/~abentley/juju-release-tools/no-sha1
Merge into: lp://staging/juju-release-tools
Diff against target: 12 lines (+1/-1)
1 file modified
make_agent_json.py (+1/-1)
To merge this branch: bzr merge lp://staging/~abentley/juju-release-tools/no-sha1
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+277250@code.staging.launchpad.net

Commit message

Remove sha1 because it is not 'sticky' and is incorrectly hoisted.

Description of the change

Remove SHA1 to avoid incorrectly "hoisting" sha1.

Due to bug 1297320, if some items have a single sha1 hash and others have no sha1 hash at all, the SHA1 hashes may be "hoisted". This will cause the hashes to be treated as if they were associated with all items, even those that had no sha1 hash. This does not happen with md5 and sha256 hashes, because they are treated specially.

SHA1 hashes are not currently required. They were added as a convenience for verifying simplestreams metadata against cloud storage metadata.

This branch removes sha1 hashes as a stopgap until simplestreams can be fixed.

Example simplestreams with broken sha1 metadata: http://temp-streams.s3.amazonaws.com/stanza-testing/agents/streams/v1/com.ubuntu.juju-revision-build-3291-tools.json

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches