Merge lp://staging/~abentley/juju-release-tools/no-debs-error into lp://staging/juju-release-tools

Proposed by Aaron Bentley
Status: Merged
Merged at revision: 284
Proposed branch: lp://staging/~abentley/juju-release-tools/no-debs-error
Merge into: lp://staging/juju-release-tools
Diff against target: 100 lines (+63/-9)
2 files modified
generate_agents.py (+21/-9)
tests/test_generate_agents.py (+42/-0)
To merge this branch: bzr merge lp://staging/~abentley/juju-release-tools/no-debs-error
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+290225@code.staging.launchpad.net

Commit message

Error when no debs are found.

Description of the change

This branch updates generate_agents to error when no debs are found.

In circumstances where the package isn't available as expected (e.g. wrong upatch), the release-juju-update-unsigned job does error, but does so quite late in the process, and not intentionally.
http://juju-ci.vapour.ws:8080/job/release-juju-update-unsigned/30/console

This branch updates generate_agents to fail immediately if it was unable to download any debs.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches