Merge lp://staging/~abentley/juju-release-tools/manta-mkdir into lp://staging/juju-release-tools

Proposed by Aaron Bentley
Status: Merged
Merged at revision: 227
Proposed branch: lp://staging/~abentley/juju-release-tools/manta-mkdir
Merge into: lp://staging/juju-release-tools
Diff against target: 327 lines (+216/-17)
4 files modified (+40/-4)
tests/ (+14/-0)
tests/ (+1/-13)
tests/ (+161/-0)
To merge this branch: bzr merge lp://staging/~abentley/juju-release-tools/manta-mkdir
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email:

Commit message

Add auto-mkdir to manta support.

Description of the change

This branch adds automatic mkdir to Manta.

It does this by handing the 404 for missing directories in the "destination path" and using that to decide to make directories.

It does not support subdirectories in target filenames; that would also require changing the way we look for existing files; right now we look for them in the "destination path", but if their name includes a subdir, we'd need to look in that subdir instead.

Note: we may not even need to list the subdir first. We could just construct the remote API urls from the local filenames and then do "HEAD", and compare the results (if any) to local.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you. I have a comment inline about FakeClient. I fear someone not familiar with it will be surprised.

review: Approve (code)
228. By Aaron Bentley

Updates from review, avoid top-level mkdir

Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches