Merge lp://staging/~abentley/juju-release-tools/make-gui-json into lp://staging/juju-release-tools

Proposed by Aaron Bentley
Status: Merged
Merged at revision: 285
Proposed branch: lp://staging/~abentley/juju-release-tools/make-gui-json
Merge into: lp://staging/juju-release-tools
Diff against target: 364 lines (+159/-55)
2 files modified (+106/-37)
tests/ (+53/-18)
To merge this branch: bzr merge lp://staging/~abentley/juju-release-tools/make-gui-json
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email:

Commit message

Add support for the GUI to

Description of the change

This branch adds support for making GUI stanzas to make_agent_jason.

It extracts the basic file-related functionality to a base class, FileStanzaWriter. It then implements GUIStanzaWriter on top. This is a simple class because it doesn't have to worry about different target platforms. It does improve on StanzaWriter by supporting sha1 hashes-- these are supported by current versions of simplestreams but were not at the time StanzaWriter was written.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches