Merge lp://staging/~abentley/juju-release-tools/append-images into lp://staging/juju-release-tools

Proposed by Aaron Bentley
Status: Merged
Merged at revision: 281
Proposed branch: lp://staging/~abentley/juju-release-tools/append-images
Merge into: lp://staging/juju-release-tools
Diff against target: 524 lines (+515/-0)
2 files modified
make_aws_image_streams.py (+204/-0)
tests/test_make_aws_image_streams.py (+311/-0)
To merge this branch: bzr merge lp://staging/~abentley/juju-release-tools/append-images
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+289380@code.staging.launchpad.net

Commit message

Support generating image streams for Centos7.

Description of the change

This branch implements support for generating Centos7 image streams.

It generates streams directly, instead of generating the intermediate JSON representation. This avoids two issues that prevented json2streams from working:
- It always uses "content-download" as the datatype.
- It fails if the JSON does not contain a 'size', even if it has no path.

It takes advantage of the Juju 2.0 credentials format, which is more convenient, even giving a standardized way of finding AWS credentials.

The product code aw0evgkw8e5c1q413zgy5pjce is used to find images. This is the official CentOS product code: https://wiki.centos.org/Cloud/AWS

This apppears to be the only way we can be certain to select the official images.

We have no aws-gov credentials, so these regions are skipped. http://cloud-images.ubuntu.com/releases/streams/v1/com.ubuntu.cloud:released:aws.json does not appear to have any existing gov entries, either.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches