Merge lp://staging/~abentley/juju-core/sign-branch-op into lp://staging/~juju-qa/juju-core/cd-release-juju

Proposed by Aaron Bentley
Status: Merged
Merged at revision: 263
Proposed branch: lp://staging/~abentley/juju-core/sign-branch-op
Merge into: lp://staging/~juju-qa/juju-core/cd-release-juju
Diff against target: 253 lines (+125/-21)
4 files modified
operation_sign_branch.py (+68/-0)
release-juju.bash (+16/-0)
sign_branch.py (+24/-8)
tests/test_sign_branch.py (+17/-13)
To merge this branch: bzr merge lp://staging/~abentley/juju-core/sign-branch-op
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+284977@code.staging.launchpad.net

Commit message

Support branch signing from release-juju.bash

Description of the change

This branch adds support for branch signing to release-juju.bash

It renames release-juju.bash to operation-release-juju.bash, and replaces it with a simple script that either calls operation-release-juju.bash or operation_sign_branch.py, depending on the specified operation.

It updates sign_branch.py to use a revision-id parameter.

It creates operation_sign_branch.py that functions much like the old release-juju.bash, except in python and for signing branches.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches