juju-ci-tools

Merge lp://staging/~abentley/juju-ci-tools/use-public-strategy into lp://staging/juju-ci-tools

  1. use-public-strategy
  2. Merge into trunk
Proposed by Aaron Bentley
Status: Merged
Merged at revision: 1720
Proposed branch: lp://staging/~abentley/juju-ci-tools/use-public-strategy
Merge into: lp://staging/juju-ci-tools
Prerequisite: lp://staging/~abentley/juju-ci-tools/public-strategy
Diff against target: 147 lines (+55/-3)
2 files modified
deploy_stack.py (+18/-1)
tests/test_deploy_stack.py (+37/-2)
To merge this branch: bzr merge lp://staging/~abentley/juju-ci-tools/use-public-strategy
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+310543@code.staging.launchpad.net

Commit message

Add --controller-host to deploy_job.

Description of the change

This branch introduces --controller-host to deploy_job.

When supplied, it causes deploy_job to register with a controller instead of bootstrapping.

This can be extended to other tests that use BootstrapManager, but it should be done on a test-by-test basis, since this change may violate test assumptions.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you. I have an idea inline that we might want to do in the future.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches