Merge lp://staging/~abentley/juju-ci-tools/no-kill-combined into lp://staging/juju-ci-tools
Proposed by
Aaron Bentley
Status: | Merged |
---|---|
Merged at revision: | 1859 |
Proposed branch: | lp://staging/~abentley/juju-ci-tools/no-kill-combined |
Merge into: | lp://staging/juju-ci-tools |
Diff against target: | 179 lines (+80/-13) |
To merge this branch: | bzr merge lp://staging/~abentley/juju-ci-tools/no-kill-combined |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+315605@code.staging.launchpad.net |
Commit message
Do not run assess_
Description of the change
Fix bug #1659326: assess_cloud "combined" also does "kill-controller"
The fix is simple, but main was untested (because main is typically painful to test). This branch adds tests for main and fixes the bug.
In order to test main, it extracts test functionality from TestAssessCloud
It also strengthens these tests by ensuring that no extra juju commands are issued. It does this by implementing strip_calls, and doing an exact match on the remaining calls.
To post a comment you must log in.
Thank you.