Merge lp://staging/~abentley/juju-ci-tools/ha-backup-logs into lp://staging/juju-ci-tools

Proposed by Aaron Bentley
Status: Merged
Merged at revision: 1788
Proposed branch: lp://staging/~abentley/juju-ci-tools/ha-backup-logs
Merge into: lp://staging/juju-ci-tools
Diff against target: 134 lines (+51/-12)
2 files modified
assess_recovery.py (+13/-10)
tests/test_assess_recovery.py (+38/-2)
To merge this branch: bzr merge lp://staging/~abentley/juju-ci-tools/ha-backup-logs
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+312488@code.staging.launchpad.net

Commit message

Ensure has_controller is True at appropriate times.

Description of the change

Ensure has_controller is True when a controller exists.

Don't let delete_controller_members set it False if leader_only=True, because presumably there remain other controllers.

And set has_controller True in restore_missing_state_server.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches