Merge lp://staging/~abentley/juju-ci-tools/fake-series into lp://staging/juju-ci-tools

Proposed by Aaron Bentley
Status: Merged
Merged at revision: 1941
Proposed branch: lp://staging/~abentley/juju-ci-tools/fake-series
Merge into: lp://staging/juju-ci-tools
Diff against target: 74 lines (+27/-2)
3 files modified
jujupy/fake.py (+6/-2)
jujupy/tests/test_fake.py (+14/-0)
tests/test_assess_mixed_images.py (+7/-0)
To merge this branch: bzr merge lp://staging/~abentley/juju-ci-tools/fake-series
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+320260@code.staging.launchpad.net

Commit message

Add dummy series to machines in fake.

Description of the change

This branch adds a 'series' field to FakeBackend's status output.

This is useful to Hammer Time, because it checks the series of a machine when deciding which operations it can perform. (Windows machines don't have iptables, for example.)

At this stage, we don't need the field to be configurable-- we just need it to exist and not start with "win". Should that change, I envision storing a dict of machine_id_to_series, similar to FakeEnvironmentState.machine_host_names.

To post a comment you must log in.
1942. By Aaron Bentley

Remove machine_series partial implementation.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you. And Thank your for using angsty to be clear that we put that series there.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches