Merge lp://staging/~abentley/juju-ci-tools/controller-strategy into lp://staging/juju-ci-tools
Proposed by
Aaron Bentley
| Status: | Merged |
|---|---|
| Merged at revision: | 1720 |
| Proposed branch: | lp://staging/~abentley/juju-ci-tools/controller-strategy |
| Merge into: | lp://staging/juju-ci-tools |
| Diff against target: |
268 lines (+129/-23) 3 files modified
deploy_stack.py (+53/-16) fakejuju.py (+15/-7) tests/test_deploy_stack.py (+61/-0) |
| To merge this branch: | bzr merge lp://staging/~abentley/juju-ci-tools/controller-strategy |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Curtis Hovey (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Introduce CreateController strategy.
Description of the change
This branch introduces the CreateController strategy for BootstrapManager.
Originally, I added support for public controllers as a series of if statements, but this grew confusing. I think it makes more sense to separate it out into strategy objects.
So there will be one Strategy object for creating a controller, and a different strategy for registering with a public controller. This branch extracts CreateController from BootstrapManager.
As part of this, it implements destroy-controller for the FakeBackend.
To post a comment you must log in.
Revision history for this message
| Aaron Bentley (abentley) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thank you. The implementation is fine, but I wonder about the behaviour of the fake