juju-ci-tools

Merge lp://staging/~abentley/juju-ci-tools/aci-updates into lp://staging/juju-ci-tools

  1. aci-updates
  2. Merge into trunk
Proposed by Aaron Bentley
Status: Merged
Merged at revision: 1737
Proposed branch: lp://staging/~abentley/juju-ci-tools/aci-updates
Merge into: lp://staging/juju-ci-tools
Diff against target: 293 lines (+89/-52)
5 files modified
assess_add_cloud.py (+1/-3)
fakejuju.py (+20/-9)
jujupy.py (+28/-7)
tests/test_assess_add_cloud.py (+1/-8)
tests/test_jujupy.py (+39/-25)
To merge this branch: bzr merge lp://staging/~abentley/juju-ci-tools/aci-updates
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+311167@code.staging.launchpad.net

Commit message

Improve add_cloud_interactive.

Description of the change

This branch improves add_cloud_interactive.

It changes it to require a 'cloud' parameter instead of looking the cloud name up in client.env.clouds. This makes it easier to use and test.

It adds detection for re-prompts of cloud name, cloud type and auth. These cause *NotAccepted errors to be raised.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches