Merge lp://staging/~abentley/ci-director/no-dupes into lp://staging/ci-director

Proposed by Aaron Bentley
Status: Merged
Merged at revision: 160
Proposed branch: lp://staging/~abentley/ci-director/no-dupes
Merge into: lp://staging/ci-director
Prerequisite: lp://staging/~abentley/ci-director/feature-branches
Diff against target: 81 lines (+37/-9)
2 files modified
cidirector/cidirector.py (+2/-1)
cidirector/tests/test_cidirector.py (+35/-8)
To merge this branch: bzr merge lp://staging/~abentley/ci-director/no-dupes
Reviewer Review Type Date Requested Status
Martin Packman (community) Approve
Review via email: mp+257144@code.staging.launchpad.net

Commit message

Avoid double-skip messages.

Description of the change

This branch changes the way branch_order is generated so that it has no duplicates. This prevents the "skipping foo (rev)" message from showing up twice in the log.

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Looks good.

I wouldn't have bothered with the extra variable, but either way works. Nice testing.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches