Merge lp://staging/~abentley/ci-director/determine-cloud-health into lp://staging/ci-director

Proposed by Aaron Bentley
Status: Merged
Merged at revision: 170
Proposed branch: lp://staging/~abentley/ci-director/determine-cloud-health
Merge into: lp://staging/ci-director
Prerequisite: lp://staging/~abentley/ci-director/extract-build-files
Diff against target: 354 lines (+249/-11)
3 files modified
cidirector/storage.py (+11/-7)
cidirector/tests/test_update_outcome.py (+150/-1)
cidirector/update_outcome.py (+88/-3)
To merge this branch: bzr merge lp://staging/~abentley/ci-director/determine-cloud-health
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+297360@code.staging.launchpad.net

Commit message

Implement pieces for determining whether a build's cloud was sickly.

Description of the change

This branch provides pieces that can be used to detect builds on sickly clouds.

It extracts get_substrate_from_parsed, so that it can be reused by get_health_match_data.

It provides get_health_match_data which describs which substrate and time window are relevant to determining whether the last build was sickly. It also provides a set of days mentioned.

load_cloud_health_data takes a set of days (i.e. from get_health_match_data) and returns a dict containing the relevant results.

find_cloud_health_builds takes a dict of cloud health data (i.e. from load_cloud_health) and finds the builds that match a given substrate and time window (i.e. from get_health_match_data).

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches