Merge lp://staging/~abentley/ci-director/allow-colon into lp://staging/ci-director
Proposed by
Aaron Bentley
| Status: | Merged |
|---|---|
| Merged at revision: | 190 |
| Proposed branch: | lp://staging/~abentley/ci-director/allow-colon |
| Merge into: | lp://staging/ci-director |
| Diff against target: |
33 lines (+11/-1) 2 files modified
cidirector/cidirector.py (+1/-1) cidirector/tests/test_cidirector.py (+10/-0) |
| To merge this branch: | bzr merge lp://staging/~abentley/ci-director/allow-colon |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Curtis Hovey (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Allow colons in ci-director config values.
Description of the change
Colons in ci-director config values break our scripts.
The problem is that the output of split(':') is fed into a two-value tuple, so when there is more than one ":", we get a ValueError: too many values to unpack.
This branch changes it so that we do split(':', 1). The first colon is treated as a separator, and the rest become part of the value.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thank you.