Merge lp://staging/~abentley/charms/precise/charmworld/worker-interval into lp://staging/~juju-jitsu/charms/precise/charmworld/trunk

Proposed by Aaron Bentley
Status: Merged
Approved by: Curtis Hovey
Approved revision: 74
Merged at revision: 74
Proposed branch: lp://staging/~abentley/charms/precise/charmworld/worker-interval
Merge into: lp://staging/~juju-jitsu/charms/precise/charmworld/trunk
Diff against target: 61 lines (+14/-5)
3 files modified
config.yaml (+4/-0)
revision (+1/-1)
scripts/write_config.py (+9/-4)
To merge this branch: bzr merge lp://staging/~abentley/charms/precise/charmworld/worker-interval
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+170127@code.staging.launchpad.net

Commit message

Control worker_interval, default 1 second.

Description of the change

This branch enables the charm to configure worker_interval: the interval the worker delays before checking for new jobs.

The default is 900 seconds, but this is not necessary, because it is a single db query, and does not impose a significant cost. 900 seconds is 15 minutes, and this is bad because the scans of LP are also on a 15-minute interval. In combination, this can mean that we wait up to 30 minutes between scans. Therefore, this branch provides a default of 1 second.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: