Merge lp://staging/~abentley/bzr-builder/usage into lp://staging/bzr-builder
Proposed by
Aaron Bentley
| Status: | Merged |
|---|---|
| Merged at revision: | 110 |
| Proposed branch: | lp://staging/~abentley/bzr-builder/usage |
| Merge into: | lp://staging/bzr-builder |
| Diff against target: |
386 lines (+125/-64) 2 files modified
recipe.py (+58/-25) tests/test_recipe.py (+67/-39) |
| To merge this branch: | bzr merge lp://staging/~abentley/bzr-builder/usage |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| James Westby | Approve | ||
| Martin Pool (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Provide USAGE in parse errors.
Description of the change
This branch adds usage info to bzr-builder's instruction parsing errors
to make it easier to fix incorrect syntax.
To post a comment you must log in.
Revision history for this message
| James Westby (james-w) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
That looks reasonable to me, though James might like to review it too.
Needing to pass around the 'instruction' quite so much suggests perhaps splitting out a class that knows the instruction it's parsing?